Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSDOCS-9803:updates CIDR ranges that are internal to OVN-K #75273

Merged
merged 1 commit into from May 16, 2024

Conversation

JoeAldinger
Copy link
Contributor

@JoeAldinger JoeAldinger commented Apr 29, 2024

Version(s):
4.14+

Issue:
https://issues.redhat.com/browse/OSDOCS-9803

Link to docs preview:
https://75273--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/cidr-range-definitions.html

QE review:

  • QE has approved this change.

Additional information:
PTAL:

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 29, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 29, 2024

@JoeAldinger: This pull request references OSDOCS-9803 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

Version(s):

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 29, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 29, 2024

@JoeAldinger: This pull request references OSDOCS-9803 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

Version(s):
4.12+

Issue:
https://issues.redhat.com/browse/OSDOCS-9803

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 29, 2024

@JoeAldinger: This pull request references OSDOCS-9803 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

Version(s):
4.12+

Issue:
https://issues.redhat.com/browse/OSDOCS-9803

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:
PTAL: @xueli181114

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 29, 2024

@JoeAldinger: This pull request references OSDOCS-9803 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

Version(s):
4.12+

Issue:
https://issues.redhat.com/browse/OSDOCS-9803

Link to docs preview:
https://75273--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/cidr-range-definitions.html

QE review:

  • QE has approved this change.

Additional information:
PTAL: @xueli181114

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 30, 2024

@JoeAldinger: This pull request references OSDOCS-9803 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

Version(s):
4.14+

Issue:
https://issues.redhat.com/browse/OSDOCS-9803

Link to docs preview:
https://75273--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/cidr-range-definitions.html

QE review:

  • QE has approved this change.

Additional information:
PTAL: @xueli181114

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented May 1, 2024

@JoeAldinger: This pull request references OSDOCS-9803 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

Version(s):
4.14+

Issue:
https://issues.redhat.com/browse/OSDOCS-9803

Link to docs preview:
https://75273--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/cidr-range-definitions.html

QE review:

  • QE has approved this change.

Additional information:
PTAL:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@JoeAldinger JoeAldinger added the peer-review-needed Signifies that the peer review team needs to review this PR label May 2, 2024
@dfitzmau
Copy link
Contributor

dfitzmau commented May 2, 2024

/remove-label peer-review-needed

/label peer-review-in-progress

@openshift-ci openshift-ci bot added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels May 2, 2024
Copy link
Contributor

@dfitzmau dfitzmau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @JoeAldinger . Feel free to ignore comments that might target text outside your changes. I just could not tell with the change history.

networking/cidr-range-definitions.adoc Outdated Show resolved Hide resolved
networking/cidr-range-definitions.adoc Outdated Show resolved Hide resolved
networking/cidr-range-definitions.adoc Outdated Show resolved Hide resolved
networking/cidr-range-definitions.adoc Show resolved Hide resolved
ifdef::openshift-enterprise[]
You can expand the range after cluster installation.

[role="_additional-resources"]
.Additional resources
* xref:../networking/cluster-network-operator.adoc#nw-operator-cr-cno-object_cluster-network-operator[Cluster Network Operator Configuration]
* xref:../networking/cluster-network-operator.adoc#nw-operator-cr-cno-object_cluster-network-operator[Cluster Network Operator Configuration]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Cluster Network Operator Configuration] > [Cluster Network Operator configuration object]

@dfitzmau
Copy link
Contributor

dfitzmau commented May 2, 2024

/remove-label peer-review-in-progress

@dfitzmau
Copy link
Contributor

dfitzmau commented May 2, 2024

/label peer-review-done

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels May 2, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 14, 2024

@JoeAldinger: This pull request references OSDOCS-9803 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

Version(s):
4.14+

Issue:
https://issues.redhat.com/browse/OSDOCS-9803

Link to docs preview:
https://75273--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/cidr-range-definitions.html

QE review:

  • QE has approved this change.

Additional information:
PTAL:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link

openshift-ci bot commented May 14, 2024

@JoeAldinger: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@zhaozhanqi
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 16, 2024
@JoeAldinger JoeAldinger merged commit b401509 into openshift:main May 16, 2024
3 checks passed
@JoeAldinger JoeAldinger deleted the OSDOCS-9803 branch May 16, 2024 11:51
@JoeAldinger
Copy link
Contributor Author

/cherrypick enterprise-4.16

@JoeAldinger
Copy link
Contributor Author

/cherrypick enterprise-4.15

@JoeAldinger
Copy link
Contributor Author

/cherrypick enterprise-4.14

@openshift-cherrypick-robot

@JoeAldinger: new pull request created: #76051

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@JoeAldinger: new pull request created: #76052

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@JoeAldinger: new pull request created: #76053

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants