Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TELCODOCS#1844: Warnings for not configuring the deviceSelector field #75265

Merged
merged 1 commit into from May 7, 2024
Merged

TELCODOCS#1844: Warnings for not configuring the deviceSelector field #75265

merged 1 commit into from May 7, 2024

Conversation

sr1kar99
Copy link
Contributor

@sr1kar99 sr1kar99 commented Apr 29, 2024 •
edited

Version(s):
4.16

Issue:
TELCODOCS-1844

Link to docs preview:
Preview

QE review:

  • QE has approved this change.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 29, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Apr 29, 2024 •
edited

🤖 Tue May 07 10:49:58 - Prow CI generated the docs preview:

https://75265--ocpdocs-pr.netlify.app/openshift-enterprise/latest/storage/persistent_storage/persistent_storage_local/persistent-storage-using-lvms.html

@sr1kar99 sr1kar99 changed the title TELCODOCS#1844: Warnings for not configuring deviceSelctor field TELCODOCS#1844: Warnings for not configuring the deviceSelector field Apr 30, 2024
@sr1kar99 sr1kar99 force-pushed the 1844-warnings-for-empty-deviceSelector branch 2 times, most recently from 8208c72 to f18aa33 Compare May 1, 2024 05:43
@sr1kar99
Copy link
Contributor Author

sr1kar99 commented May 1, 2024

@suleymanakbas91
Could you please review this PR?
Thanks!

@suleymanakbas91
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 2, 2024
@sr1kar99
Copy link
Contributor Author

sr1kar99 commented May 6, 2024

@radeore
Can you please review this PR?
Thanks!

@sr1kar99 sr1kar99 force-pushed the 1844-warnings-for-empty-deviceSelector branch from f18aa33 to 5e6fcb1 Compare May 6, 2024 08:47
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 6, 2024
@radeore
Copy link

radeore commented May 6, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 6, 2024
@sr1kar99
Copy link
Contributor Author

sr1kar99 commented May 7, 2024

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label May 7, 2024
@xenolinux
Copy link
Contributor

/label peer-review-in-progress

@openshift-ci openshift-ci bot added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label May 7, 2024
xenolinux
xenolinux reviewed May 7, 2024
View reviewed changes
Copy link
Contributor

@xenolinux xenolinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of suggestions; Nice work!

/remove-label peer-review-needed
/remove-label peer-review-in-progress
/label peer-review-done

modules/lvms-about-adding-devices-to-a-vg.adoc Show resolved Hide resolved
modules/lvms-about-adding-devices-to-a-vg.adoc Outdated Show resolved Hide resolved
modules/lvms-about-adding-devices-to-a-vg.adoc Outdated Show resolved Hide resolved
modules/lvms-about-adding-devices-to-a-vg.adoc Outdated Show resolved Hide resolved
modules/lvms-about-adding-devices-to-a-vg.adoc Outdated Show resolved Hide resolved
modules/lvms-about-adding-devices-to-a-vg.adoc Outdated Show resolved Hide resolved
modules/lvms-about-adding-devices-to-a-vg.adoc Outdated Show resolved Hide resolved
modules/lvms-about-adding-devices-to-a-vg.adoc Outdated Show resolved Hide resolved
@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR peer-review-in-progress Signifies that the peer review team is reviewing this PR labels May 7, 2024
@sr1kar99 sr1kar99 force-pushed the 1844-warnings-for-empty-deviceSelector branch from 5e6fcb1 to 6876242 Compare May 7, 2024 10:44
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 7, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 7, 2024

New changes are detected. LGTM label has been removed.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 7, 2024

@sr1kar99: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sr1kar99
Copy link
Contributor Author

sr1kar99 commented May 7, 2024

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label May 7, 2024
@skopacz1 skopacz1 added merge-review-in-progress Signifies that the merge review team is reviewing this PR branch/enterprise-4.16 labels May 7, 2024
@skopacz1 skopacz1 added this to the Planned for 4.16 GA milestone May 7, 2024
skopacz1
skopacz1 approved these changes May 7, 2024
View reviewed changes
Copy link
Contributor

@skopacz1 skopacz1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge review LGTM!

@skopacz1 skopacz1 merged commit 1f8296a into openshift:main May 7, 2024
3 checks passed
@skopacz1
Copy link
Contributor

skopacz1 commented May 7, 2024

/cherrypick enterprise-4.16

@openshift-cherrypick-robot
Copy link

@skopacz1: new pull request created: #75612

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 7, 2024
Merged
@skopacz1 skopacz1 removed merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR labels May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suleymanakbas91 suleymanakbas91 suleymanakbas91 left review comments

@xenolinux xenolinux xenolinux left review comments

@skopacz1 skopacz1 skopacz1 approved these changes

Assignees

@suleymanakbas91 suleymanakbas91

@radeore radeore

Labels
branch/enterprise-4.16 peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
Planned for 4.16 GA
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@sr1kar99 @ocpdocs-previewbot @suleymanakbas91 @radeore @xenolinux @skopacz1 @openshift-cherrypick-robot