Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OBSDOCS-953/TRACING-4062 Write documentation and technical enablement for journald component #75257

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

max-cx
Copy link
Contributor

@max-cx max-cx commented Apr 29, 2024

⚠️ Note for the peer reviewer: In response to a peer review for my other PR where I was asked to replace the Technology Preview links with the Technology Preview admonition boxes, I will do so in my next PR. If I did this in this PR, we would end up with a style discrepancy on this page. So my plan is to keep the PR scopes separate and limited.

Signed-off-by: Pavol Loffay p.loffay@gmail.com

Edit of #74207

Version(s):

4.12, 4.13, 4.14, 4.15, 4.16

This PR should be published as part of RHOSDT 3.2 release

Issue:

https://issues.redhat.com/browse/OBSDOCS-953
https://issues.redhat.com/browse/TRACING-4062

Link to docs preview:

https://75257--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/otel/otel-configuration-of-otel-collector.html#journald-receiver_otel-configuration-of-otel-collector

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 29, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Apr 29, 2024

@max-cx
Copy link
Contributor Author

max-cx commented Apr 29, 2024

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Apr 29, 2024
@mburke5678 mburke5678 added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Apr 29, 2024
@mburke5678
Copy link
Contributor

@max-cx A few nits. Otherwise LGTM

@mburke5678 mburke5678 added peer-review-done Signifies that the peer review team has reviewed this PR branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Apr 29, 2024
Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
Copy link

openshift-ci bot commented May 8, 2024

@max-cx: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants