-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ansible.cfg: improve ssh ControlPath #4705
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AWS hosts and user names frequently make the default Ansible ControlPath too long. This prevents ssh persistent connections, significantly impacting runtime. More detail: ansible/ansible#11536 This config change shortens the ControlPath to make this less likely. It would be better to change it to the %C hash, as extremely long hostnames or usernames could still encounter this problem, but that is not yet available with RHEL's openssh. This at least improves the situation.
aos-ci-test |
[test] |
Evaluated for openshift ansible test up to 94a5c89 |
continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_openshift_ansible/326/) (Base Commit: 5f49d32) (PR Branch Commit: 94a5c89) |
Merged
@tbielawa test failure was nothing... can I get a thumbs up? |
merged in #4737 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AWS hosts and user names frequently make the default Ansible ControlPath
too long. This prevents ssh persistent connections, significantly
impacting runtime. More detail: ansible/ansible#11536
This config change shortens the ControlPath to make this less likely. It
would be better to change it to the %C hash, as extremely long hostnames
or usernames could still encounter this problem, but that is not yet
available with RHEL's openssh. This at least improves the situation.