Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create e2e for namespaceSelector #79

Merged
merged 2 commits into from May 3, 2024

Conversation

lwan-wanglin
Copy link
Contributor

for MULTIARCH-4316

  • Add opt-out and opt-in namespaceSelector testing in pkg/e2e/operator
  • there is some common func lile deploymentsAreRunning ``deploymentsAreDeleted and verifyPodNodeAffinity, should they be in utils.go?

@lwan-wanglin
Copy link
Contributor Author

@aleskandro could you help to review? thanks!

pkg/e2e/operator/pod_placement_config_test.go Outdated Show resolved Hide resolved
pkg/e2e/operator/pod_placement_config_test.go Outdated Show resolved Hide resolved
pkg/e2e/operator/pod_placement_config_test.go Outdated Show resolved Hide resolved
pkg/e2e/operator/pod_placement_config_test.go Outdated Show resolved Hide resolved
pkg/e2e/operator/pod_placement_config_test.go Outdated Show resolved Hide resolved
@aleskandro
Copy link
Member

/lgtm

@aleskandro
Copy link
Member

/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 3, 2024
Copy link

openshift-ci bot commented May 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aleskandro

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 3, 2024
@aleskandro
Copy link
Member

/test e2e-gcp-multi-operator-olm

@aleskandro
Copy link
Member

/override "Red Hat Konflux / Red Hat Konflux / multiarch-tuning-operator-enterprise-contract / multiarch-tuning-operator"

Copy link

openshift-ci bot commented May 3, 2024

@aleskandro: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • Red Hat Konflux / Red Hat Konflux / multiarch-tuning-operator-enterprise-contract / multiarch-tuning-operator

Only the following failed contexts/checkruns were expected:

  • Red Hat Konflux / multiarch-tuning-operator-enterprise-contract / multiarch-tuning-operator
  • ci/prow/bundle
  • ci/prow/ci-index-multiarch-tuning-operator-bundle
  • ci/prow/e2e-gcp-multi-operator
  • ci/prow/e2e-gcp-multi-operator-olm
  • ci/prow/fmt
  • ci/prow/generate
  • ci/prow/goimports
  • ci/prow/images
  • ci/prow/lint
  • ci/prow/manifests
  • ci/prow/sast
  • ci/prow/security
  • ci/prow/unit
  • ci/prow/vendor
  • ci/prow/vet
  • pull-ci-openshift-multiarch-tuning-operator-main-bundle
  • pull-ci-openshift-multiarch-tuning-operator-main-ci-index-multiarch-tuning-operator-bundle
  • pull-ci-openshift-multiarch-tuning-operator-main-e2e-gcp-multi-operator
  • pull-ci-openshift-multiarch-tuning-operator-main-e2e-gcp-multi-operator-olm
  • pull-ci-openshift-multiarch-tuning-operator-main-fmt
  • pull-ci-openshift-multiarch-tuning-operator-main-generate
  • pull-ci-openshift-multiarch-tuning-operator-main-goimports
  • pull-ci-openshift-multiarch-tuning-operator-main-images
  • pull-ci-openshift-multiarch-tuning-operator-main-lint
  • pull-ci-openshift-multiarch-tuning-operator-main-manifests
  • pull-ci-openshift-multiarch-tuning-operator-main-sast
  • pull-ci-openshift-multiarch-tuning-operator-main-security
  • pull-ci-openshift-multiarch-tuning-operator-main-unit
  • pull-ci-openshift-multiarch-tuning-operator-main-vendor
  • pull-ci-openshift-multiarch-tuning-operator-main-vet
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override "Red Hat Konflux / Red Hat Konflux / multiarch-tuning-operator-enterprise-contract / multiarch-tuning-operator"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aleskandro
Copy link
Member

/override "Red Hat Konflux / multiarch-tuning-operator-enterprise-contract / multiarch-tuning-operator"

Copy link

openshift-ci bot commented May 3, 2024

@aleskandro: Overrode contexts on behalf of aleskandro: Red Hat Konflux / multiarch-tuning-operator-enterprise-contract / multiarch-tuning-operator

In response to this:

/override "Red Hat Konflux / multiarch-tuning-operator-enterprise-contract / multiarch-tuning-operator"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 43018b2 and 2 for PR HEAD 20e9d77 in total

@aleskandro
Copy link
Member

/retest-required

@aleskandro
Copy link
Member

gcp installation is having issues

/override ci/prow/e2e-gcp-multi-operator-olm

Copy link

openshift-ci bot commented May 3, 2024

@aleskandro: Overrode contexts on behalf of aleskandro: ci/prow/e2e-gcp-multi-operator-olm

In response to this:

gcp installation is having issues

/override ci/prow/e2e-gcp-multi-operator-olm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aleskandro
Copy link
Member

/override "Red Hat Konflux / multiarch-tuning-operator-enterprise-contract / multiarch-tuning-operator"

Copy link

openshift-ci bot commented May 3, 2024

@aleskandro: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • Red Hat Konflux / multiarch-tuning-operator-enterprise-contract / multiarch-tuning-operator

Only the following failed contexts/checkruns were expected:

  • ci/prow/bundle
  • ci/prow/ci-index-multiarch-tuning-operator-bundle
  • ci/prow/e2e-gcp-multi-operator
  • ci/prow/e2e-gcp-multi-operator-olm
  • ci/prow/fmt
  • ci/prow/generate
  • ci/prow/goimports
  • ci/prow/images
  • ci/prow/lint
  • ci/prow/manifests
  • ci/prow/sast
  • ci/prow/security
  • ci/prow/unit
  • ci/prow/vendor
  • ci/prow/vet
  • pull-ci-openshift-multiarch-tuning-operator-main-bundle
  • pull-ci-openshift-multiarch-tuning-operator-main-ci-index-multiarch-tuning-operator-bundle
  • pull-ci-openshift-multiarch-tuning-operator-main-e2e-gcp-multi-operator
  • pull-ci-openshift-multiarch-tuning-operator-main-e2e-gcp-multi-operator-olm
  • pull-ci-openshift-multiarch-tuning-operator-main-fmt
  • pull-ci-openshift-multiarch-tuning-operator-main-generate
  • pull-ci-openshift-multiarch-tuning-operator-main-goimports
  • pull-ci-openshift-multiarch-tuning-operator-main-images
  • pull-ci-openshift-multiarch-tuning-operator-main-lint
  • pull-ci-openshift-multiarch-tuning-operator-main-manifests
  • pull-ci-openshift-multiarch-tuning-operator-main-sast
  • pull-ci-openshift-multiarch-tuning-operator-main-security
  • pull-ci-openshift-multiarch-tuning-operator-main-unit
  • pull-ci-openshift-multiarch-tuning-operator-main-vendor
  • pull-ci-openshift-multiarch-tuning-operator-main-vet
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override "Red Hat Konflux / multiarch-tuning-operator-enterprise-contract / multiarch-tuning-operator"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-bot openshift-merge-bot bot merged commit ffcca62 into openshift:main May 3, 2024
18 of 19 checks passed
Copy link

openshift-ci bot commented May 3, 2024

@lwan-wanglin: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants