Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.13] OCPBUGS-32015: Fix zone tag value reconciliation for vSphere machines #1225

Open
wants to merge 1 commit into
base: release-4.13
Choose a base branch
from
Open

[release-4.13] OCPBUGS-32015: Fix zone tag value reconciliation for vSphere machines #1225

wants to merge 1 commit into from

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #1126

/assign rvanderp3

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 9, 2024
Merged
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-7249 has been cloned as Jira Issue OCPBUGS-32015. Will retitle bug to link to clone.

WARNING: Failed to update the target version, assignee, and sprint for the clone. Please update these fields manually. Full error below:

Full error message. assignee - User 'dmoiseev' cannot be assigned issues.: request failed. Please analyze the request body for more details. Status code: 400:
/retitle [release-4.13] OCPBUGS-32015: Fix zone tag value reconciliation for vSphere machines

In response to this:

This is an automated cherry-pick of #1126

/assign rvanderp3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [release-4.13] OCPBUGS-7249: Fix zone tag value reconciliation for vSphere machines [release-4.13] OCPBUGS-32015: Fix zone tag value reconciliation for vSphere machines Apr 9, 2024
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Apr 9, 2024
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-32015, which is invalid:

  • expected the bug to target either version "4.13." or "openshift-4.13.", but it targets "4.14.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #1126

/assign rvanderp3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Apr 9, 2024
@lobziik
Fix zone value reconciliation for vSphere machines
0090997 
VCenter does not return 'Cluster' object as a VM ancestor,
use VM's host system instead.

Also, this commit introduces using of CachingTagsManager for region/zone tags
info obtaining, instead of constructing a non-caching one.
@openshift-ci openshift-ci bot requested review from elmiko and JoelSpeed April 9, 2024 19:50
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 9, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign elmiko for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vr4manta
Copy link
Contributor

/retest-required

@vr4manta
Copy link
Contributor

/assign @vr4manta

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 22, 2024

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-vsphere-operator 0090997 link false /test e2e-vsphere-operator
ci/prow/e2e-vsphere-ovn-upgrade 0090997 link false /test e2e-vsphere-ovn-upgrade
ci/prow/unit 0090997 link true /test unit

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elmiko elmiko Awaiting requested review from elmiko

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

Assignees

@vr4manta vr4manta

@rvanderp3 rvanderp3

Labels
jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@openshift-cherrypick-robot @openshift-ci-robot @vr4manta @rvanderp3 @lobziik