Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OLS-506: Remove standalone script #846

Merged

Conversation

onmete
Copy link
Contributor

@onmete onmete commented Apr 30, 2024

Description

Remove standalone script

  • Update default test tags to not run cluster tests locally.

TODO

- Update default test tags to not run cluster tests locally.
@onmete onmete changed the title Remove standalone script OLS-506: Remove standalone script Apr 30, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 30, 2024

@onmete: This pull request references OLS-506 which is a valid jira issue.

In response to this:

Description

Remove standalone script

  • Update default test tags to not run cluster tests locally.

TODO

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 30, 2024
@openshift-ci openshift-ci bot requested review from bparees and thoraxe April 30, 2024 11:34
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.57%. Comparing base (5ea99d8) to head (8c91ff5).
Report is 7 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #846   +/-   ##
=======================================
  Coverage   94.57%   94.57%           
=======================================
  Files          55       55           
  Lines        2009     2009           
=======================================
  Hits         1900     1900           
  Misses        109      109           

@onmete onmete marked this pull request as draft April 30, 2024 11:40
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 30, 2024
Copy link

openshift-ci bot commented Apr 30, 2024

@onmete: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ols-bam-granite13b-chat-v2 8c91ff5 link true /test e2e-ols-bam-granite13b-chat-v2
ci/prow/e2e-ols-azure-openai-gpt35 8c91ff5 link true /test e2e-ols-azure-openai-gpt35

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@onmete
Copy link
Contributor Author

onmete commented May 2, 2024

/retest

@onmete onmete marked this pull request as ready for review May 2, 2024 08:34
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 2, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 2, 2024

@onmete: This pull request references OLS-506 which is a valid jira issue.

In response to this:

Description

Remove standalone script

  • Update default test tags to not run cluster tests locally.

TODO

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from tisnik May 2, 2024 08:34
@bparees
Copy link
Contributor

bparees commented May 2, 2024

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 2, 2024
Copy link

openshift-ci bot commented May 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 2, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 46aa50a into openshift:main May 2, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants