New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CORS-3466: CAPG set instance group name #8314
Conversation
@patrickdillon: This pull request references CORS-3466 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/label platform/google |
/test altinfra-e2e-gcp-ovn |
@patrickdillon: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test altinfra-e2e-gcp-capi-ovn |
Just need one more change to use "master" here instead of "apiserver" https://github.com/openshift/installer/blob/master/pkg/infrastructure/gcp/clusterapi/network.go#L133 The instancegroups are now properly named, e.g.:
|
21806c0
to
79e05c3
Compare
Thanks. Pushed! That's the same error as ci turned up. Let's see if this fixes it! /test altinfra-e2e-gcp-capi-ovn |
/retest |
77b46c3
to
b59516a
Compare
/test altinfra-e2e-gcp-capi-ovn |
1 similar comment
/test altinfra-e2e-gcp-capi-ovn |
b59516a
to
a459e1c
Compare
/test altinfra-e2e-gcp-capi-ovn |
nice, after a failure in the last run install has completed!
|
capi e2es failed with:
Running another e2e test to see which failures stick: e2e failures shouldn't be a blocker for this PR, but we will need to determine if any of these failures are caused by the capi install process. |
/retest-required |
/retest-required only
is failing now |
/cc |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/cc @bfournie
/lgtm to me bob what do you think?
oh ok I see the replace in the provider. will fix tomorrow. firewall as I have it is not fixing the e2e. so let's tackle that separately. |
It looks like the service-type-load-balancer-availability test which was failing before is now passing after the healthcheck fix |
It looks like that result is coming from periodic-ci-openshift-release-master-ci-4.16-e2e-gcp-ovn. which is still on terraform. the capi presubmit is still failing the e2e: https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_installer/8314/pull-ci-openshift-installer-master-altinfra-e2e-gcp-capi-ovn/1785766397066874880 |
That was from the alinfra test " |
fixed oauth replace in 02fa61c I removed the commit containing the attempted fix at the ingress e2e test failure. will follow up in a separate pr |
/retest |
/test altinfra-e2e-gcp-capi-ovn |
/retest |
/test altinfra-e2e-gcp-capi-ovn |
/test altinfra-e2e-gcp-capi-ovn The previous runs had a build error which I missed locally because my cached binary was skipping the build. This resolves the build error but oauth2 is still unpinned. I still need to resolve that |
Pulls in changes needed for custom instance groups. go get sigs.k8s.io/cluster-api-provider-gcp@main go mod tidy
go mod vendor
Pulls in custom instance group functionality. go get sigs.k8s.io/cluster-api-provider-gcp@main && go mod tidy
go mod vendor
Updates CAPG infra components to bring in customizable instance groups.
Sets the instance group role tag to "master" to be consistent with the role tag expected by MAPI--rather than "apiserver" used by CAPI.
/test altinfra-e2e-gcp-capi-ovn |
1 similar comment
/test altinfra-e2e-gcp-capi-ovn |
/retest-required |
Install succeeded on the last run, but looks like there were CI scheduling issues that caused a lot of jobs to fail. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@patrickdillon: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
a6d9a1a
into
openshift:master
[ART PR BUILD NOTIFIER] This PR has been included in build ose-baremetal-installer-container-v4.17.0-202405040320.p0.ga6d9a1a.assembly.stream.el9 for distgit ose-baremetal-installer. |
Sets the instance group name in capg to user "master" to be compatible with MAPI conventions, rather than "apiserver" as used by CAPI.