Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AGENT-871: Authenticate wait for #8270

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pawanpinjarkar
Copy link
Contributor

@pawanpinjarkar pawanpinjarkar commented Apr 15, 2024

  • Base64 encode ECDSA public, private keys
  • Set Authorization header param in the client. The client is then used to send requests to assisted-service when running wait-for command

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 15, 2024
Copy link
Contributor

openshift-ci bot commented Apr 15, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@pawanpinjarkar
Copy link
Contributor Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 15, 2024
@pawanpinjarkar pawanpinjarkar force-pushed the authenticate-wait-for branch 5 times, most recently from 1e2fc74 to 90ff3b8 Compare April 16, 2024 14:19
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 18, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 7, 2024
@pawanpinjarkar pawanpinjarkar force-pushed the authenticate-wait-for branch 3 times, most recently from 63fa078 to e4beb80 Compare May 10, 2024 17:37
@pawanpinjarkar pawanpinjarkar marked this pull request as ready for review May 10, 2024 17:38
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 10, 2024
@openshift-ci openshift-ci bot requested review from bfournie and rwsu May 10, 2024 17:39
Copy link
Contributor

openshift-ci bot commented May 10, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from pawanpinjarkar. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pawanpinjarkar pawanpinjarkar force-pushed the authenticate-wait-for branch 3 times, most recently from 47f84ce to 552d619 Compare May 11, 2024 03:52
@pawanpinjarkar pawanpinjarkar changed the title Authenticate wait for AGENT-871: Authenticate wait for May 11, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 11, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 11, 2024

@pawanpinjarkar: This pull request references AGENT-871 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to this:

  • Base64 encode ECDSA public, private keys
  • Set Authorization header param in the client. The client is then used to send requests to assisted-service when running wait-for command

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@pawanpinjarkar
Copy link
Contributor Author

pawanpinjarkar commented May 13, 2024

Please note, this PR adds the code necessary to authenticate wait-for requests, however, the complete functionality to work end to end depends on below PRs

And most importantly, updating the auth type env var

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 13, 2024
@pawanpinjarkar
Copy link
Contributor Author

/cc @zaneb @andfasano

@pawanpinjarkar
Copy link
Contributor Author

/retest-required

- Base64 encode ECDSA public, private keys
- Set Authorization header param in the client
Copy link
Contributor

openshift-ci bot commented May 20, 2024

@pawanpinjarkar: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-e2e-agent-compact-ipv4 ff40351 link false /test okd-e2e-agent-compact-ipv4
ci/prow/okd-images ff40351 link true /test okd-images
ci/prow/e2e-agent-compact-ipv4 ff40351 link true /test e2e-agent-compact-ipv4
ci/prow/golint ff40351 link true /test golint
ci/prow/okd-e2e-aws-ovn-upgrade ff40351 link false /test okd-e2e-aws-ovn-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants