New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AGENT-871: Authenticate wait for #8270
base: master
Are you sure you want to change the base?
AGENT-871: Authenticate wait for #8270
Conversation
Skipping CI for Draft Pull Request. |
/hold |
1e2fc74
to
90ff3b8
Compare
90ff3b8
to
f7b95b6
Compare
63fa078
to
e4beb80
Compare
e4beb80
to
6364cb9
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
47f84ce
to
552d619
Compare
@pawanpinjarkar: This pull request references AGENT-871 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
552d619
to
de46116
Compare
Please note, this PR adds the code necessary to authenticate wait-for requests, however, the complete functionality to work end to end depends on below PRs
And most importantly, updating the auth type env var /hold cancel |
/cc @zaneb @andfasano |
/retest-required |
- Base64 encode ECDSA public, private keys - Set Authorization header param in the client
de46116
to
ff40351
Compare
@pawanpinjarkar: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
wait-for
command