OCPBUGS-33961: OCPBUGS-33890: SPLAT-1469: Remove vsphere terraform #8254

jcpowermac · 2024-04-10T18:39:25Z

This PR:

Removes all vSphere terraform providers
Removes all vSphere-specific terraform project files
Modifies vsphere-specific installer terraform stages and asset generation.

openshift-bot · 2024-04-10T18:39:29Z

@jcpowermac: This pull request references SPLAT-1469 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

jcpowermac · 2024-04-11T16:47:27Z

/test altinfra-e2e-vsphere-capi-ovn

jcpowermac · 2024-04-11T17:45:06Z

/test altinfra-e2e-vsphere-capi-ovn

openshift-ci-robot · 2024-04-11T18:08:15Z

@jcpowermac: This pull request references SPLAT-1469 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to this:

This PR:

All vSphere terraform providers

All vSphere-specific terraform project files

Modifies vsphere-specific installer terraform stages and asset generation.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2024-04-11T18:17:08Z

@jcpowermac: This pull request references SPLAT-1469 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to this:

This PR:

Removes all vSphere terraform providers

Removes all vSphere-specific terraform project files

Modifies vsphere-specific installer terraform stages and asset generation.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

jcpowermac · 2024-04-22T13:38:15Z

/jira refresh

openshift-ci-robot · 2024-04-22T13:38:19Z

@jcpowermac: This pull request references SPLAT-1469 which is a valid jira issue.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

jcpowermac · 2024-04-22T13:49:18Z

@r4f4 since time is short can you take a look and see if this seems sane?

Since this PR will break periodics we can't actually merge this until capi is built by default.

pkg/asset/cluster/tfvars/tfvars.go

jcpowermac · 2024-04-22T16:54:08Z

/test altinfra-e2e-vsphere-capi-ovn

r4f4 · 2024-04-22T18:12:46Z

~~LGTM~~. I'll tag when we're closer to merging it.
Edit: actually, we cannot fail to generate the terraform variables since that's a req for vsphere/capi:
https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_installer/8254/pull-ci-openshift-installer-master-altinfra-e2e-vsphere-capi-ovn/1782452952850501632#1:build-log.txt%3A173

I'll check if there is a better way of failing in the terraform case.

r4f4 · 2024-04-23T14:07:01Z

@jcpowermac sorry for the delay on getting back to you on this.
I don't have access to a vcenter, so I couldn't test it with vsphere. Instead, I did the same to AWS. Here's what I suggest:

On pkg/asset/cluster/tfvars/tfvars.go you go back to what you had before with return nil
On pkg/infrastructure/platform/platform.go you change the line:

-               return terraform.InitializeProvider(vsphere.PlatformStages), nil
+               return nil, fmt.Errorf("installing on vSphere via terraform is no longer supported")

As a bonus of 2), you can now remove pkg/terraform/stages/vsphere

This is what I can with the above changes for AWS:

 ./openshift-install create cluster
INFO Credentials loaded from the "default" profile in file "/run/secrets/aws_credentials"
INFO Creating infrastructure resources...
FATAL failed to fetch Cluster: failed to generate asset "Cluster": error getting infrastructure provider: installing on AWS via terraform is no longer supported

and the capi install works as expected.

In the end I think none of this will matter because capi-vsphere will be the default path and there will be no way to trigger the tf path.

jcpowermac · 2024-04-23T16:33:15Z

/test altinfra-e2e-vsphere-capi-ovn

@jcpowermac sorry for the delay on getting back to you on this.

no worries, thanks for sending suggestions!

jcpowermac · 2024-04-23T16:36:42Z

👋 buh bye terraform

sadasu · 2024-05-17T21:16:16Z

/override ci/prow/shellcheck

openshift-ci · 2024-05-17T21:16:33Z

@sadasu: Overrode contexts on behalf of sadasu: ci/prow/shellcheck

In response to this:

/override ci/prow/shellcheck

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

sadasu · 2024-05-17T21:16:50Z

/approve

openshift-ci · 2024-05-17T21:17:26Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sadasu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [sadasu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

sadasu · 2024-05-17T21:17:40Z

/override ci/prow/shellcheck

shellcheck was failing due to:
./docs/user/agent/add-node/node-joiner-monitor.sh:10:13: warning: Assigning an array to a string! Assign as array, or use * instead of @ to concatenate. [SC2124]
which is unrelated to these changes.

openshift-ci-robot · 2024-05-17T22:51:33Z

/retest-required

Remaining retests: 0 against base HEAD fde8335 and 2 for PR HEAD e5a4c42 in total

jcpowermac · 2024-05-18T14:59:17Z

/test okd-images

jcpowermac · 2024-05-18T17:33:21Z

/test okd-images

openshift-ci · 2024-05-18T18:48:40Z

@jcpowermac: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-agent-compact-ipv4	`23a5e69`	link	true	`/test e2e-agent-compact-ipv4`
ci/prow/okd-e2e-aws-ovn-upgrade	`e5a4c42`	link	false	`/test okd-e2e-aws-ovn-upgrade`
ci/prow/e2e-vsphere-zones-techpreview	`e5a4c42`	link	false	`/test e2e-vsphere-zones-techpreview`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

jcpowermac · 2024-05-18T19:23:32Z

@sadasu @patrickdillon can we override okd-images?

patrickdillon · 2024-05-19T02:34:05Z

/override ci/prow/okd-images

openshift-ci · 2024-05-19T02:34:22Z

@patrickdillon: Overrode contexts on behalf of patrickdillon: ci/prow/okd-images

In response to this:

/override ci/prow/okd-images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci-robot · 2024-05-19T02:38:50Z

@jcpowermac: Jira Issue OCPBUGS-33890: All pull requests linked via external trackers have merged:

openshift/installer#8254

Jira Issue OCPBUGS-33890 has been moved to the MODIFIED state.

In response to this:

This PR:

Removes all vSphere terraform providers

Removes all vSphere-specific terraform project files

Modifies vsphere-specific installer terraform stages and asset generation.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

jcpowermac · 2024-05-19T11:57:12Z

/cherrypick release-4.16

jcpowermac · 2024-05-19T12:09:42Z

/cherry-pick release-4.16

jcpowermac · 2024-05-20T11:18:08Z

its going to work this time right? 🤞
/cherrypick release-4.16

jcpowermac · 2024-05-20T11:22:17Z

/jira refresh

openshift-ci-robot · 2024-05-20T11:22:19Z

@jcpowermac: Jira Issue OCPBUGS-33890 is in an unrecognized state (MODIFIED) and will not be moved to the MODIFIED state.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

jcpowermac · 2024-05-20T11:22:33Z

/cherrypick release-4.16

jcpowermac · 2024-05-20T11:38:45Z

/jira cherrypick OCPBUGS-33890

openshift-ci-robot · 2024-05-20T11:39:53Z

@jcpowermac: Jira Issue OCPBUGS-33890 has been cloned as Jira Issue OCPBUGS-33961. Will retitle bug to link to clone.
/retitle OCPBUGS-33961: OCPBUGS-33890: SPLAT-1469: Remove vsphere terraform

In response to this:

/jira cherrypick OCPBUGS-33890

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2024-05-20T11:40:26Z

@jcpowermac: Jira Issue OCPBUGS-33961: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-33961 has been moved to the MODIFIED state.

In response to this:

This PR:

Removes all vSphere terraform providers

Removes all vSphere-specific terraform project files

Modifies vsphere-specific installer terraform stages and asset generation.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

…emove-terraform" This reverts commit dcd7435, reversing changes made to fde8335.

openshift-bot · 2024-05-20T17:59:07Z

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-installer-altinfra-container-v4.17.0-202405201608.p0.gdcd7435.assembly.stream.el9 for distgit ose-installer-altinfra.
All builds following this will include this PR.

openshift-bot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 10, 2024

openshift-ci bot requested review from patrickdillon and rwsu April 10, 2024 18:53

jcpowermac force-pushed the remove-terraform branch from c26bf4f to 6f0eaa9 Compare April 11, 2024 16:25

jcpowermac force-pushed the remove-terraform branch from 6f0eaa9 to 23a5e69 Compare April 11, 2024 17:31

r4f4 reviewed Apr 22, 2024

View reviewed changes

pkg/asset/cluster/tfvars/tfvars.go Show resolved Hide resolved

jcpowermac force-pushed the remove-terraform branch from 23a5e69 to cf94102 Compare April 22, 2024 16:53

jcpowermac force-pushed the remove-terraform branch from cf94102 to e927e5b Compare April 23, 2024 16:32

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 2, 2024

jcpowermac added 3 commits May 9, 2024 13:13

remove vsphere terraform providers

12ae39f

remove vsphere terrform project files

f804699

vsphere installer terraform changes

e5a4c42

jcpowermac force-pushed the remove-terraform branch from e927e5b to e5a4c42 Compare May 9, 2024 17:15

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 9, 2024

patrickdillon mentioned this pull request May 16, 2024

OCPBUGS-33880: CORS-2840: promote capi-installers to default feature set #8416

Merged

jcpowermac changed the title ~~SPLAT-1469: Remove vsphere terraform~~ OCPBUGS-33890: SPLAT-1469: Remove vsphere terraform May 17, 2024

openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label May 17, 2024

openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label May 17, 2024

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 17, 2024

openshift-merge-bot bot merged commit dcd7435 into openshift:master May 19, 2024
36 of 38 checks passed

openshift-ci bot changed the title ~~OCPBUGS-33890: SPLAT-1469: Remove vsphere terraform~~ OCPBUGS-33961: OCPBUGS-33890: SPLAT-1469: Remove vsphere terraform May 20, 2024

patrickdillon mentioned this pull request May 20, 2024

Revert #8416 "OCPBUGS-33880: CORS-2840: promote capi-installers to default feature set" #8432

Closed

neisw added a commit to neisw/installer that referenced this pull request May 20, 2024

Revert "Merge pull request openshift#8254 from openshift-splat-team/r…

3ca8f15

…emove-terraform" This reverts commit dcd7435, reversing changes made to fde8335.

neisw mentioned this pull request May 20, 2024

TRT-1674: 4.17 capi revert 1 #8433

Merged

OCPBUGS-33961: OCPBUGS-33890: SPLAT-1469: Remove vsphere terraform #8254

OCPBUGS-33961: OCPBUGS-33890: SPLAT-1469: Remove vsphere terraform #8254

Conversation

jcpowermac commented Apr 10, 2024 • edited

openshift-bot commented Apr 10, 2024 • edited by openshift-ci bot

jcpowermac commented Apr 11, 2024

jcpowermac commented Apr 11, 2024

openshift-ci-robot commented Apr 11, 2024 • edited by openshift-ci bot

openshift-ci-robot commented Apr 11, 2024 • edited by openshift-ci bot

jcpowermac commented Apr 22, 2024

openshift-ci-robot commented Apr 22, 2024 • edited by openshift-ci bot

jcpowermac commented Apr 22, 2024

jcpowermac commented Apr 22, 2024

r4f4 commented Apr 22, 2024 • edited

r4f4 commented Apr 23, 2024

jcpowermac commented Apr 23, 2024

jcpowermac commented Apr 23, 2024

sadasu commented May 17, 2024

openshift-ci bot commented May 17, 2024

sadasu commented May 17, 2024

openshift-ci bot commented May 17, 2024

sadasu commented May 17, 2024

openshift-ci-robot commented May 17, 2024

jcpowermac commented May 18, 2024

jcpowermac commented May 18, 2024

openshift-ci bot commented May 18, 2024 • edited

jcpowermac commented May 18, 2024

patrickdillon commented May 19, 2024

openshift-ci bot commented May 19, 2024

openshift-ci-robot commented May 19, 2024

jcpowermac commented May 19, 2024

jcpowermac commented May 19, 2024

jcpowermac commented May 20, 2024

jcpowermac commented May 20, 2024

openshift-ci-robot commented May 20, 2024

jcpowermac commented May 20, 2024

jcpowermac commented May 20, 2024

openshift-ci-robot commented May 20, 2024 • edited by openshift-ci bot

openshift-ci-robot commented May 20, 2024

openshift-bot commented May 20, 2024

jcpowermac commented Apr 10, 2024 •

edited

openshift-bot commented Apr 10, 2024 •

edited by openshift-ci bot

openshift-ci-robot commented Apr 11, 2024 •

edited by openshift-ci bot

openshift-ci-robot commented Apr 11, 2024 •

edited by openshift-ci bot

openshift-ci-robot commented Apr 22, 2024 •

edited by openshift-ci bot

r4f4 commented Apr 22, 2024 •

edited

openshift-ci bot commented May 18, 2024 •

edited

openshift-ci-robot commented May 20, 2024 •

edited by openshift-ci bot