Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CORS-3457: Remove pborman/uuid dependency #8250

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

CORS-3457: Remove pborman/uuid dependency #8250

wants to merge 1 commit into from

Conversation

mikelolasagasti
Copy link
Contributor

google/uuid module is being used in other parts of the code and pborman/uuid is not maintained.

@mikelolasagasti
Remove pborman/uuid dependency
c25415e 
`google/uuid` module is being used in other parts of the code and
`pborman/uuid` is not maintained.

Signed-off-by: Mikel Olasagasti Uranga <mikel@olasagasti.info>
@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 10, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 10, 2024

Hi @mikelolasagasti. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@r4f4
Copy link
Contributor

r4f4 commented Apr 13, 2024

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 13, 2024
@r4f4
Copy link
Contributor

r4f4 commented Apr 13, 2024 •
edited by openshift-ci bot

/retitle CORS-3457: Remove pborman/uuid dependency

@openshift-ci openshift-ci bot changed the title Remove pborman/uuid dependency CORS-3457: Remove pborman/uuid dependency Apr 13, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 13, 2024 •
edited by openshift-ci bot

@mikelolasagasti: This pull request references CORS-3457 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

google/uuid module is being used in other parts of the code and pborman/uuid is not maintained.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 13, 2024
@sadasu
Copy link
Contributor

sadasu commented Apr 25, 2024

/retest-required

@zaneb
Copy link
Member

zaneb commented Apr 25, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 25, 2024
@zaneb
Copy link
Member

zaneb commented Apr 25, 2024

/retest-required

@sadasu
Copy link
Contributor

sadasu commented May 1, 2024

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sadasu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 1, 2024
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 1593f7f and 2 for PR HEAD c25415e in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 2238c31 and 1 for PR HEAD c25415e in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD adb699e and 0 for PR HEAD c25415e in total

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 2, 2024

@mikelolasagasti: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-e2e-aws-ovn-upgrade c25415e link false /test okd-e2e-aws-ovn-upgrade
ci/prow/verify-vendor c25415e link true /test verify-vendor

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link
Contributor

/hold

Revision c25415e was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bfournie bfournie Awaiting requested review from bfournie

@patrickdillon patrickdillon Awaiting requested review from patrickdillon

Assignees

@zaneb zaneb

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mikelolasagasti @r4f4 @openshift-ci-robot @sadasu @zaneb