Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNM: CAPG/MAPI Instance group compatibility workaround #8238

Closed

Conversation

patrickdillon
Copy link
Contributor

DO NOT MERGE

Directly updates the in-repo vendored code as a PoC to demonstrate creating an instance group in CAPG which has the same naming conventions as MAPI. This can be used for testing or workarounding the issue until we can merge a fix upstream.

DO NOT MERGE

Directly updates the in-repo vendored code as a PoC to demonstrate
creating an instance group in CAPG which has the same naming
conventions as MAPI.

Updates the dependent load balancer code to use the MAPI naming
convention.
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 6, 2024
Copy link
Contributor

openshift-ci bot commented Apr 6, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link
Contributor

openshift-ci bot commented Apr 6, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from patrickdillon. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bfournie
Copy link
Contributor

bfournie commented Apr 7, 2024

/label platform/google

Copy link
Contributor

openshift-ci bot commented Apr 16, 2024

@patrickdillon: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-agent-compact-ipv4 e68ebb6 link true /test e2e-agent-compact-ipv4

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@patrickdillon
Copy link
Contributor Author

/close
in favor of #8314

@openshift-ci openshift-ci bot closed this May 1, 2024
Copy link
Contributor

openshift-ci bot commented May 1, 2024

@patrickdillon: Closed this PR.

In response to this:

/close
in favor of #8314

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. platform/google
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants