Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2090816: Increase bootstrap timeout, not k8s API timeout #6010

Merged
merged 1 commit into from
Jun 16, 2022

Conversation

honza
Copy link
Member

@honza honza commented Jun 15, 2022

This fixes a previous change where we mistakenly increased the
Kubernetes API timeout instead of the bootstrap timeout.

This fixes a previous change where we mistakenly increased the
Kubernetes API timeout instead of the bootstrap timeout.
@honza honza changed the title Bugu 2090816: Increase bootstrap timeout, not k8s API timeout Bug 2090816: Increase bootstrap timeout, not k8s API timeout Jun 15, 2022
@openshift-ci openshift-ci bot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jun 15, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 15, 2022

@honza: This pull request references Bugzilla bug 2090816, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2090816: Increase bootstrap timeout, not k8s API timeout

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@honza
Copy link
Member Author

honza commented Jun 15, 2022

/bugzilla refresh

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jun 15, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 15, 2022

@honza: This pull request references Bugzilla bug 2090816, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.11.0) matches configured target release for branch (4.11.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @awolffredhat

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from awolffredhat June 15, 2022 14:25
@derekhiggins
Copy link
Contributor

/lgtm
from the metal-ipi job

level=debug msg=Built from commit 83211d26348738777578d6459ca2dee6cc6e4726
level=info msg=Waiting up to 20m0s (until 3:53PM) for the Kubernetes API at https://api.ostest.test.metalkube.org:6443...
...
level=info msg=Waiting up to 1h0m0s (until 4:33PM) for bootstrapping to complete...

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 15, 2022
@sdodson
Copy link
Member

sdodson commented Jun 16, 2022

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 16, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sdodson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 16, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 16, 2022

@honza: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi e4f7e09 link false /test e2e-metal-ipi
ci/prow/e2e-libvirt e4f7e09 link false /test e2e-libvirt
ci/prow/e2e-ibmcloud e4f7e09 link false /test e2e-ibmcloud
ci/prow/e2e-crc e4f7e09 link false /test e2e-crc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot merged commit e20220f into openshift:master Jun 16, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 16, 2022

@honza: All pull requests linked via external trackers have merged:

Bugzilla bug 2090816 has been moved to the MODIFIED state.

In response to this:

Bug 2090816: Increase bootstrap timeout, not k8s API timeout

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@honza
Copy link
Member Author

honza commented Jun 16, 2022

/cherrypick release-4.10

@openshift-cherrypick-robot

@honza: #6010 failed to apply on top of branch "release-4.10":

Applying: Increase bootstrap timeout, not k8s API timeout
Using index info to reconstruct a base tree...
M	cmd/openshift-install/create.go
Falling back to patching base and 3-way merge...
Auto-merging cmd/openshift-install/create.go
CONFLICT (content): Merge conflict in cmd/openshift-install/create.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Increase bootstrap timeout, not k8s API timeout
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@naumvd95
Copy link

Hello folks! @honza @derekhiggins, wanted to pay your attention that the higher timeout needed not only for

// Name is the name for the baremetal platform.
const Name string = "baremetal"

but for all platforms where BM instances used. AFAIU its +1 extra case at the current moment - its AWS metal instances. And that's exact our problem =(

#7326

It would be awesome if you find some time to provide a fix for such case :)

thanks in advance and have a great day!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants