OCPBUGS-30260: Ignore subnet annotations for control plane load balancers

[csrwng]

What this PR does / why we need it:
Partially reverts behavior introduced with #3746
We need to figure out why specifying subnets results in a broken load balancer.

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #OCPBUGS-30260

Checklist

• Subject and description added to both, commit and PR.
• Relevant issues have been referenced.

[openshift-ci-robot]

@csrwng: This pull request references Jira Issue OCPBUGS-30260, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.16.0) matches configured target version for branch (4.16.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (jiezhao@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

What this PR does / why we need it:
Partially reverts behavior introduced with #3746
We need to figure out why specifying subnets results in a broken load balancer.

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #OCPBUGS-30260

Checklist

• Subject and description added to both, commit and PR.
• Relevant issues have been referenced.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[muraee]

/lgtm

[csrwng]

/area control-plane-operator

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csrwng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [csrwng]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD a72e581 and 2 for PR HEAD f057485 in total

[csrwng]

/retest-required

[csrwng]

/override "Red Hat Konflux / hypershift-operator-main-on-pull-request"

[openshift-ci]

@csrwng: Overrode contexts on behalf of csrwng: Red Hat Konflux / hypershift-operator-main-on-pull-request

In response to this:

/override "Red Hat Konflux / hypershift-operator-main-on-pull-request"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[csrwng]

/retest

[openshift-ci]

@csrwng: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci-robot]

@csrwng: Jira Issue OCPBUGS-30260: Some pull requests linked via external trackers have merged:

• openshift/hypershift#3746
• openshift/hypershift#3767
• openshift/hypershift#3944

The following pull requests linked via external trackers have not merged:

• openshift/hypershift#3946 is open

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-30260 has not been moved to the MODIFIED state.

In response to this:

What this PR does / why we need it:
Partially reverts behavior introduced with #3746
We need to figure out why specifying subnets results in a broken load balancer.

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #OCPBUGS-30260

Checklist

• Subject and description added to both, commit and PR.
• Relevant issues have been referenced.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.