Remove dependency on os dpuoperatorconfig controller #35
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bn222 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/test e2e-dpu-operator-tests |
bn222
force-pushed
the
bindata
branch
3 times, most recently
from
79ae26f
to
e071c79
Compare
|
/retest |
|
/test e2e-dpu-operator-tests |
3 similar comments
|
/test e2e-dpu-operator-tests |
|
/test e2e-dpu-operator-tests |
|
/test e2e-dpu-operator-tests |
|
This depends on #61 |
|
/override ci/prow/e2e-dpu-operator-tests |
|
@bn222: Overrode contexts on behalf of bn222: ci/prow/e2e-dpu-operator-tests In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
bn222
force-pushed
the
bindata
branch
2 times, most recently
from
26f3ad6
to
c065f40
Compare
bn222
changed the title
Embed the files into the reconciler. The net effect of this is: 1. Remove depenency on os from the reconciler 2. Make it easier to initialize the reconciler Signed-off-by: Balazs Nemeth <bnemeth@redhat.com>
There was a problem hiding this comment.
Why do we need to move the files?
There was a problem hiding this comment.
Because:
- The files are not relevant top level2
- The embedding works relatively to the embed line.
| ctrl "sigs.k8s.io/controller-runtime" | ||
| "sigs.k8s.io/controller-runtime/pkg/client" | ||
| "sigs.k8s.io/controller-runtime/pkg/log" | ||
| ) | ||
|
|
||
| //go:embed bindata/* |
There was a problem hiding this comment.
I guess this can't reference the root directory?
There was a problem hiding this comment.
Correct. It works relatively to the .go file, which is nice because as long as the .go file lives in the same directory as the embedded files, this will work.
|
/override ci/prow/e2e-dpu-operator-tests |
|
/test remaining-required |
|
@bn222: Overrode contexts on behalf of bn222: ci/prow/e2e-dpu-operator-tests In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/lgtm |
|
@bn222: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/override ci/prow/e2e-dpu-operator-tests |
|
@bn222: Overrode contexts on behalf of bn222: ci/prow/e2e-dpu-operator-tests In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
No description provided.