OCPBUGS-34399: Exposing chunksize variable to utilize docker registry config

[deepsm007]

Trying to work around a bug for r2 integration with s3 bucket, exposing chunksize variable by utilizing the docker registry S3 driver configuration option: https://docker-docs.uclv.cu/registry/storage-drivers/s3/

/hold for openshift/api#1864 to merge

https://issues.redhat.com//browse/IR-471

/cc @flavianmissi

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: deepsm007
Once this PR has been reviewed and has the lgtm label, please assign adambkaplan for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[deepsm007]

/test all

[deepsm007]

/test all

[flavianmissi]

so far so good, I'll put it on hold until the o/api changes merge (your hold didn't take).
/hold

[deepsm007]

/retest-required

[deepsm007]

/retest

[flavianmissi]

unit test failing:

{  === RUN   TestMakePodTemplateSpecS3CloudFront
    podtemplatespec_test.go:560: expected env var REGISTRY_STORAGE_S3_CHUNKSIZE not found

since this env var is optional, should the test really be expecting it?

[flavianmissi]

Looks like there might be some permissions missing from the operator as well, seeing this in the logs:

W0522 05:55:27.620106       1 reflector.go:539] github.com/openshift/client-go/config/informers/externalversions/factory.go:125: 
failed to list *v1.FeatureGate: featuregates.config.openshift.io is forbidden: 
User "system:serviceaccount:openshift-image-registry:cluster-image-registry-operator" cannot list 
resource "featuregates" in API group "config.openshift.io" at the cluster scope

https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/pr-logs/pull/openshift_cluster-image-registry-operator/1026/pull-ci-openshift-cluster-image-registry-operator-master-e2e-aws-ovn-upgrade/1793105514377252864/artifacts/e2e-aws-ovn-upgrade/gather-extra/artifacts/pods/openshift-image-registry_cluster-image-registry-operator-787b97fc95-pgxmm_cluster-image-registry-operator.log

[flavianmissi]

Where is the change that actually adds the chunksize env var to image registry pod spec? I think maybe that's why that unit test was failing? In that case, maybe we should add it back (sorry...)?

[deepsm007]

/test all

[deepsm007]

/test e2e-aws-ovn-image-registry

[deepsm007]

/unhold

[openshift-ci-robot]

@deepsm007: This pull request references Jira Issue OCPBUGS-34399, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.17.0) matches configured target version for branch (4.17.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @xiuwang

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Trying to work around a bug for r2 integration with s3 bucket, exposing chunksize variable by utilizing the docker registry S3 driver configuration option: https://docker-docs.uclv.cu/registry/storage-drivers/s3/

/hold for openshift/api#1864 to merge

/cc @flavianmissi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@deepsm007: This pull request references Jira Issue OCPBUGS-34399, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.17.0) matches configured target version for branch (4.17.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @xiuwang

In response to this:

Trying to work around a bug for r2 integration with s3 bucket, exposing chunksize variable by utilizing the docker registry S3 driver configuration option: https://docker-docs.uclv.cu/registry/storage-drivers/s3/

/hold for openshift/api#1864 to merge

/cc @flavianmissi

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[deepsm007]

/retest

[deepsm007]

/retest

[openshift-ci]

@deepsm007: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-vsphere	bb32361	link	false	/test e2e-vsphere
ci/prow/e2e-vsphere-operator	bb32361	link	true	/test e2e-vsphere-operator
ci/prow/e2e-openstack	bb32361	link	false	/test e2e-openstack
ci/prow/e2e-azure-operator	a62f325	link	false	/test e2e-azure-operator
ci/prow/e2e-azure-ovn	a62f325	link	false	/test e2e-azure-ovn
ci/prow/e2e-hypershift-conformance	a62f325	link	true	/test e2e-hypershift-conformance
ci/prow/e2e-hypershift	a62f325	link	true	/test e2e-hypershift

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.