[ART-7273] add modifications to support go 1.19 rhel8 wrapper #3409
Conversation
|
/lgtm |
|
I don't believe that the additional_tags should be commented out. CPaaS relies on these tags to stay up-to-date. The original script removed these tags because the changes were incompatible with CPaaS. The changes should now be safe for CPaaS consumption and we can continue to update the tags. |
images/openshift-golang-builder.yml
Outdated
| additional_tags: | ||
| - 'rhel_8_golang_1.19' | ||
| - 'rhel_8_1.19' | ||
| # additional_tags: |
There was a problem hiding this comment.
No need to comment these out in any of the golang branches / PRs.
Ximinhan
force-pushed
the
rhel-8-golang-1.19
branch
from
edaf174
to
71e805d
Compare
|
/lgtm |
joepvd
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: joepvd The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-robot
merged commit 4e4c7b8
into
openshift-eng:rhel-8-golang-1.19
add go wrapper during golang build process, the wrapper script will get from openshift-eng/doozer#811