[ART-7273] add modifications to support go wrapper #3309
Conversation
Ximinhan
changed the title
Ximinhan
changed the title
images/openshift-golang-builder.yml
Outdated
| modifications: | ||
| - action: replace | ||
| match: "# FOD wrapper modification" | ||
| replacement: "COPY go_wrapper.sh /tmp/go_wrapper.sh |
There was a problem hiding this comment.
I think I'd rather see this script in Dockerfile directly, than the comment to be used as a replacement placeholder.
There was a problem hiding this comment.
ok, seem directly hack in dockerfile is straightforward
| match: "# FOD wrapper modification" | ||
| replacement: "COPY go_wrapper.sh /tmp/go_wrapper.sh | ||
| RUN /bin/bash -c 'GO_BIN_PATH=`which go`; mv $GO_BIN_PATH $GO_BIN_PATH.real; mv /tmp/go_wrapper.sh $GO_BIN_PATH; chmod +x $GO_BIN_PATH'" | ||
| - action: add |
There was a problem hiding this comment.
doozer is running the rebase code, so would have access to the shell file of the current commit. Think it'd be nicer to not add a network call to master, but to load the file while rebasing.
There was a problem hiding this comment.
the way to use modification method is trying to not add extra logic in images:rebase. I tried to no using URL but that seems the only pattern that ADD modification support. Unless we try to add relative path for add modification function in doozer, I added openshift-eng/doozer@253992d
Ximinhan
force-pushed
the
rhel-9-golang-1.20
branch
from
9dc217a
to
f7f6fce
Compare
Ximinhan
changed the title
|
/lgtm |
bug in ci ? |
|
oh, there are no owners file in this branch https://github.com/openshift-eng/ocp-build-data/blob/rhel-9-golang-1.20/OWNERS |
joepvd
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: joepvd The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-robot
merged commit cdaafde
into
openshift-eng:rhel-9-golang-1.20
add go wrapper during golang build process, the wrapper script will get from doozer repo