Conversation
@@ -1829,10 +1829,10 @@ def config_rhcos_src(runtime: Runtime, version, output, brew_root, arch): | |||
out_src_dir = out_base_dir_path.joinpath('src') | |||
if out_src_dir.exists(): | |||
if out_src_dir.is_symlink(): | |||
print(f'Output directory already contains a symlink for {package_nvr}. Skipping.') | |||
runtime.logger.info(f'Output directory already contains a symlink for {package_nvr}. Skipping.') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a message info which should not print to output
Build #1
|
Build #2
|
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #808 +/- ##
==========================================
+ Coverage 35.45% 38.38% +2.93%
==========================================
Files 47 52 +5
Lines 11779 12471 +692
Branches 2576 2634 +58
==========================================
+ Hits 4176 4787 +611
- Misses 7311 7351 +40
- Partials 292 333 +41
☔ View full report in Codecov by Sentry. |
Build #3
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
only print correct data to output