This repository has been archived by the owner on Oct 13, 2023. It is now read-only.
[ART-6709] update pr title with relate issue bug #795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build #1 |
joepvd
suggested changes
Jul 7, 2023
Build #2 |
Build #3 |
Build #4 |
Build #5 |
locriandev
reviewed
Jul 10, 2023
Build #6 |
locriandev
reviewed
Jul 10, 2023
Build #7 |
Ximinhan
commented
Jul 12, 2023
| @@ -1237,8 +1260,6 @@ def check_if_upstream_image_exists(upstream_image): | |||
| # In one execution to date, get_pulls did not find the open PR and the code repeatedly hit this | |||
| # branch -- attempting to recreate the PR. Everything seems right, but the github api is not | |||
| # returning it. So catch the error and try to move on. | |||
| pr_url = f'UnknownPR-{fork_branch_head}' | |||
| pr_links[dgk] = pr_url | |||
There was a problem hiding this comment.
since we will use pr_links to do jira connection in the following step, such exception info is not useful in pr_links list.
Build #8 |
Build #9 |
Build #10 |
Build #11 |
vfreex
reviewed
Jul 14, 2023
doozerlib/cli/images_streams.py
Outdated
| @@ -1189,7 +1212,7 @@ def check_if_upstream_image_exists(upstream_image): | |||
| yellow_print(f'Unable to add labels to {existing_pr.html_url}: {str(pr_e)}') | |||
|
|
|||
| pr_url = existing_pr.html_url | |||
| pr_links[dgk] = pr_url | |||
| pr_links[dgk] = existing_pr | |||
There was a problem hiding this comment.
Also pr_links should be renamed since it no longer means "PR links".
There was a problem hiding this comment.
update pr_links to pr_dgk_map
doozerlib/cli/images_streams.py
Outdated
| pr.edit(title=f"{issue}: {pr.title}") | ||
|
|
||
|
|
||
| def reconcile_jira_issues(runtime, pr_links: Dict[str, PullRequest.PullRequest], dry_run: bool): |
There was a problem hiding this comment.
Parameter name pr_links is not appropriate.
There was a problem hiding this comment.
update the parameter pr_links to pr_map
doozerlib/cli/images_streams.py
Outdated
| """ | ||
| if issue in pr.title: # the issue already in pr title | ||
| return | ||
| elif "OCPBUGS" in pr.title: # another issue is in pr title, add comment |
There was a problem hiding this comment.
Let's be more concise. Instead of testing OCPBUGS in PR title, check if matches = re.findall(r'OCPBUGS-[0-9]+', pr.title) is empty, where you did in line 625.
Build #12 |
Build #13 |
Build #14 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref https://issues.redhat.com/browse/ART-6709
update pr title with relate issue bug