This repository has been archived by the owner on Oct 13, 2023. It is now read-only.
WIP: [ART-3965] scan-sources: Use repoquery for rpm change detection #783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vfreex
changed the title
Build #1 |
vfreex
changed the title
vfreex
force-pushed
the
scan_sources_with_repoquery
branch
from
35c153c
to
e4543ab
Compare
Build #2 |
|
Needs more testing to see if this will cause unnecessary rebuild before deploying this to production. Cases to consider:
|
In openshift-eng#764, the idea of using repoquery to detect outdated rpms has been proved in `gen-payload`. This PR will adopt the same approach in `scan_sources`.
vfreex
force-pushed
the
scan_sources_with_repoquery
branch
from
e4543ab
to
6e23bcb
Compare
Build #3 |
locriandev
reviewed
Jun 20, 2023
| arch_rpms[arch].append(rpm_entry) | ||
|
|
||
| self.logger.info(f'Checking whether any of the installed rpms {len(arch_rpms)} is outdated') | ||
| loop = asyncio.new_event_loop() |
There was a problem hiding this comment.
calling asyncio.new_event_loop() within a synchronous function has shown to be problematic in the past. I think we should make does_image_need_change async, and with it config_scan_source_changes that calls it. We might even replace current runtime.parallel_exec with a cleaner asyncio.gather if feasible, but since we're quering koji API this might make the process slower. It might even be a nice chance to look into how to wrap those synchronous API and make them async
| @@ -1077,6 +973,6 @@ async def find_non_latest_rpms(self) -> Dict[str, List[Tuple[str, str, str]]]: | |||
| for arch in arches: | |||
| iar = self.get_image_archive_inspector(arch) | |||
| assert iar is not None | |||
There was a problem hiding this comment.
We might use an error message in case the assertion fails that explains what is causing it and how it could be addressed
Build #4 |
Build #5 |
Build #6 |
Build #7 |
Build #8 |
Build #9 |
Build #10 |
|
Replaced by a new PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #764, the idea of using repoquery to detect outdated rpms has been proved in
gen-payload. This PR will adopt the same approach inscan_sources.Example run: