This repository has been archived by the owner on Oct 13, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 26
ART-6099: Add a command to support weekly kernel ingestion #772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vfreex
force-pushed
the
tag-rpms
branch
3 times, most recently
from
May 25, 2023 10:02
ded04a7
to
6c54082
Compare
A new command `config:tag-rpms` is added to scan RPMs (usually kernel and kernel-rt) in the integration Brew tag defined in group config then tag acceptable builds into the target Brew tag. "acceptable" here means the build is not tagged into stop_ship_tag or historically tagged into the target tag. e.g. With the following config, Doozer will try to find latest acceptable builds of kernel and kernel-rt from Brew tag early-kernel-integration-8.6, then tag them into Brew tag rhaos-4.11-rhel-8-candidate. Additionally, all builds in tag early-kernel-stop-ship will be untagged from rhaos-4.11-rhel-8-candidate. rpm_deliveries: - packages: - kernel - kernel-rt integration_tag: early-kernel-integration-8.6 stop_ship_tag: early-kernel-stop-ship ship_ok_tag: early-kernel-ship-ok target_tag: rhaos-4.11-rhel-8-candidate This command does nothing if `rpm_deliveries` is not set in group config or an entry in `rpm_deliveries` doesn't have `target_tag`. A dry run mode is also provided to show which builds would be tagged and untagged.
Build #5
|
Build #6
|
Build #7
|
Build #8
|
joepvd
approved these changes
Jun 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
sosiouxme
reviewed
Jun 26, 2023
return [task.result for task in tasks] | ||
task_ids = cast(List[int], await exectools.to_thread(_func)) | ||
if task_ids: | ||
TASK_URL = "https://brewweb.engineering.redhat.com/brew/taskinfo?taskID=" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we have a constant BREWWEB_URL
for this although it would be even better to be configurable in case some day we find the brew stage deployment useful
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new command
config:tag-rpms
is added to scan RPMs (usually kernel and kernel-rt) in the integration Brew tag defined in group config then tag acceptable builds into the target Brew tag. "acceptable" here means the build is not tagged into stop_ship_tag or historically tagged into the target tag.e.g. With the following config, Doozer will try to find latest acceptable builds of kernel and kernel-rt from Brew tag early-kernel-integration-8.6, then tag them into Brew tag rhaos-4.11-rhel-8-candidate. Additionally, all builds in tag early-kernel-stop-ship will be untagged from rhaos-4.11-rhel-8-candidate.
This command does nothing if
rpm_deliveries
is not set in group config or an entry inrpm_deliveries
doesn't havetarget_tag
.A dry run mode is also provided to show which builds would be tagged and untagged.
Test command: