Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use component name consistent for reconciliation #97

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

ashwindasr
Copy link
Contributor

@ashwindasr ashwindasr commented Oct 10, 2023

Ref openshift-eng/doozer#818

Ready to merge. Requesting lgtm and approve

https://github.com/openshift-eng/ocp-build-data/blob/main/product.yml uses component name to map issues to owners. Use of distgit
name in PRs/tickets has led to confusion when updating product.yml.
Prevent this by using component name everywhere.

Original PR openshift-eng/doozer#818
@thegreyd thegreyd changed the title Migrate doozer#818 Use component name consistent for reconciliation Oct 10, 2023
@thegreyd
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 10, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: thegreyd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 10, 2023
@openshift-ci openshift-ci bot merged commit 116de0d into openshift-eng:main Oct 10, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants