Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter out eol versions when running scheduled-jobs #4149

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

thegreyd
Copy link
Contributor

@thegreyd thegreyd commented May 7, 2024

To mark a version eol we have 2 places, one is our group.yml config and another
is ocp4Versions constant in this repo. We have marking version as eol in config, but
jobs still run for all versions in ocp4Versions. This is so that we filter these eol versions
out for jobs that don't need to run for eol versions.

Test:
https://art-jenkins.apps.prod-stable-spoke1-dc-iad2.itup.redhat.com/job/hack/job/sidsharm-aos-cd-jobs/job/build%252Focp4_scan/17/console

Copy link
Contributor

openshift-ci bot commented May 7, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from thegreyd. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@thegreyd thegreyd changed the title Filter out eol versions when running jobs Filter out eol versions when running scheduled-jobs May 8, 2024
Copy link
Contributor

openshift-ci bot commented May 8, 2024

@thegreyd: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security 0688ba7 link false /test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@thegreyd
Copy link
Contributor Author

thegreyd commented May 8, 2024

@thegreyd thegreyd added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant