Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix 4 of 5 peer dependency warnings by updating dependencies #394

Conversation

sschmidTU
Copy link
Contributor

This is a PR for PR #384.
It fixes 4 of the 5 npm warnings for npm install that tell you to install peer dependencies.

The remaining warning seems unsolvable right now, because we also need a newer version of webpack:

npm WARN karma-webpack@3.0.4 requires a peer of webpack@^2.0.0 || ^3.0.0 but none is installed.
You must install peer dependencies yourself.

karma-webpack upgrades the webpack dependency in 4.0.0, but there's only a release candidate for that right now.

for tsify's dependency on browserify, i had to add browserify to the devDependencies. It's not ideal, because tsify might change that peer dependency in the future and then we can remove browserify as a dependency. But better than a warning, i think.

everything seems to work fine with this (npm install, karma tests, npm start, demo).

Copy link
Collaborator

@bneumann bneumann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. @sebastian we need browserify?

@bneumann bneumann merged commit f2ea931 into chore/updateDependencies Sep 18, 2018
@bneumann bneumann deleted the chore/updateDependencies-fix-peer-dependencies branch September 18, 2018 17:53
bneumann added a commit that referenced this pull request Sep 18, 2018
#384)

* chore(Updating out dependencies): Since CI was failing greekeeper kept failing too

#381,#365,#364

* chore(Dependencies): fix 4 of 5 peer dependency warnings by updating dependencies (#394)
@sschmidTU
Copy link
Contributor Author

sschmidTU commented Sep 18, 2018

We need browserify as a peer dependency for tsify. i wrote about it above. i think tsify won't abandon browserify so soon, so it's a decent tradeoff to add it i think.

edit: since tsify is a browserify plugin and we don't use it anymore, we don't need either of them. removed these dev dependencies.
see #103 for move from browserify to Webpack

sschmidTU added a commit that referenced this pull request Dec 4, 2018
both packages not used in the project anymore since we switched to webpack.
(tsify is a plugin for browserify)

fixes npm audit warnings for browserify

we probably missed this in #384 (adding browserify) and #394 (keeping tsify).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants