solve #751 by adding spec.port.0.appProtocol: "HTTPS" for compliance with GKE gateways
#769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhardy92
requested review from
idanl21,
dbason,
swoehrl-mw,
prudhvigodithi,
jochenkressin,
pchmielnik and
salyh
as code owners
|
@dhardy92 Before we can get this PR merged, please refer to the PR guideline and add the mssing prerequisites. Thank you very much. |
dhardy92
force-pushed
the
dhardy92/751-AddService0AppProtocolHTTPS
branch
from
73c3db9
to
364ac09
Compare
…h-project#751) ### Description Adding `spec.port.0.appProtocol: "HTTPS"` for compliance with GKE gateways cf : https://cloud.google.com/kubernetes-engine/docs/how-to/secure-gateway#load-balancer-tls ### Issues Resolved Fixes opensearch-project#751 By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. For more information on following Developer Certificate of Origin and signing off your commits, please check [here](https://github.com/opensearch-project/OpenSearch/blob/main/CONTRIBUTING.md#developer-certificate-of-origin). --------- Signed-off-by: Damien HARDY <dhardy@figarocms.fr> Signed-off-by: dhardy <dhardy@figarocms.fr>
dhardy92
force-pushed
the
dhardy92/751-AddService0AppProtocolHTTPS
branch
from
364ac09
to
c63e628
Compare
|
Hello there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As Operator deploy only HTTPS cluster this PR just add a static
AppProtocol: "HTTPS"in port[0] of opensearch service (9200 default).This properties let possible GKE gateway to now to use this backend with TLS protocol as described in https://cloud.google.com/kubernetes-engine/docs/how-to/secure-gateway#load-balancer-tls
Issues Resolved
solve issue #751
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.