Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/2061 - Add KPNS #2072

Open
wants to merge 13 commits into
base: develop
Choose a base branch
from
Open

feature/2061 - Add KPNS #2072

wants to merge 13 commits into from

Conversation

svalencia014
Copy link

Resolves #2061

The purpose of this pull request is to add Pensicola

@render
Copy link

render bot commented Jan 26, 2023

@svalencia014 svalencia014 added WIP Add this label to work-in-progress PRs which are not yet ready for review DO NOT MERGE PR author's request to not merge a pull request labels Jan 26, 2023
@erikquinn erikquinn changed the title Feature/2061 - Add KPNS feature/2061 - Add KPNS Jan 27, 2023
@erikquinn erikquinn added airport/airline/aircraft Changes to airport/airline/aircraft files feature Addition of a COMPLETELY NEW feature and removed DO NOT MERGE PR author's request to not merge a pull request labels Jan 27, 2023
@svalencia014
Copy link
Author

svalencia014 commented Feb 22, 2023

TODO:

  • Fix Departure Runways (Updated since file was made)
  • Generate Terrain File

@svalencia014 svalencia014 marked this pull request as ready for review February 28, 2023 15:17
@svalencia014 svalencia014 requested a review from a team February 28, 2023 15:18
Copy link
Member

@Fechulo Fechulo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Make sure to add an airport guide as well

assets/airports/kpns.json Outdated Show resolved Hide resolved
assets/airports/kpns.json Outdated Show resolved Hide resolved
assets/airports/airportLoadList.json Outdated Show resolved Hide resolved
@svalencia014
Copy link
Author

svalencia014 commented Mar 1, 2023

TODO:

  • Create Airport Guide

assets/airports/kpns.json Outdated Show resolved Hide resolved
"WABEN": ["N030d040m12.227", "W087d014m26.464"],
"ZUGTI": ["N030d044m42.820", "W088d003m48.735"]
},
"restricted": [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The coordinates don't seem quite right

Compare these:
image
image

W-155 has two arcs on it's north edge which seem to be centered on the NPA VOR (I could be wrong, you may find better information)

The south edge of R-2908 should line up perfectly with W-155

It looks like there's some self intersecting lines in the R-2915 polygon currently. It may be easier to separate it into its different sections

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@svalencia014 Definitely better, but there's still some issues.

  • The R2908 doesn't line up with the video map at all, feel free to take the coordinates straight from the video map instead.
  • The W155 is still missing its arcs. You can use GPSVisualizer to try calculate the coordinates, or, perhaps easier, take the coordinates used in the video map.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The initial coordinates were pulled directly from the PNS video maps in the VRC Sector file provided by ZJX, and they supposedly "don't seem right". Do you want me to use the video map or not?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If they're straight from the video map, they should line up with the video map. Could be coordinate conversion issue maybe. I'd have to have a look at the original VRC file to see if I can find anything

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
airport/airline/aircraft Changes to airport/airline/aircraft files feature Addition of a COMPLETELY NEW feature WIP Add this label to work-in-progress PRs which are not yet ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add PNS - Pensacola Intl, FL
4 participants