[v6] Drop support for browsers without native BigInts (e.g. Safari <14) #1754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove BN.js fallback, and only keep native BigInteger interface (for algorithmic constant-time functions). Also, add support for TS modules, to move some over from the forked noble repos.
twiss
reviewed
May 6, 2024
The main repo doesn't implement them
larabr
force-pushed
the
v6-drop-bigint-fallback
branch
from
3968008
to
25db839
Compare
larabr
force-pushed
the
v6-drop-bigint-fallback
branch
2 times, most recently
from
f538f45
to
1093ff9
Compare
larabr
force-pushed
the
v6-drop-bigint-fallback
branch
from
1093ff9
to
785482e
Compare
twiss
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BigIntis not polyfillable, and in order to support legacy browsers that do not implement it natively (e.g. Safari <14), a large alternative library (BN.js) needs to be bundled as well, and imported also by modern browsers (in OpenPGP.js v6, which depends the@noblelibs).We're finally dropping the fallback support as usage of Safari 11-13 has gone down significantly.
Aside from optimising the bundle size, thanks to the change we reduce the number of forked dependencies we need to maintain.