-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: 1次精度ラプラシアンを実装(粘性項のみ) #41
Draft
LWisteria
wants to merge
8
commits into
master
Choose a base branch
from
30-1st_order_laplacian
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
中心重力や水中崩壊のベンチマークを実行中です。 |
中心重力問題をやりました。#53 の問題があるのでSPPを外しています。あと半径を20にしました。 結果は全然駄目でした 1LじゃなくてHLの結果と比べると、
単体テストは通っているんですけどね・・・。実装バグがありそうなので見直します。 |
調べてみたら単体試験通ってませんでした。
不合格なのはNeighborDensityTestですね
|
単体試験が落ちるやつ、SPPを導入していないとそもそもmasterでも落ちますね・・・(↑の「このPR最新」にはNeighborDensityVariationの試験は入ってなかった)。別問題っぽい。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#30 を考えていたら、HLよりこっちの方が精度が良いのではと言う気がしてきたので