[BREAKING] Remove name_en and name_de #928
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes openmaptiles#796 and includes some of the same code as in openmaptiles#910 (rebased) by @kukulich This PR removes both `name_en` and `name_de` fields from all layers. This PR requires some changes to the styling as well: current styles use `name_en` and `name_de` instead of `name:en` and `name:de`. All other languages are already done in the new system. TODO: decide how to handle `name_int` and `name_latin`.
|
Results evaluating commit 9bcc519 (merged with base ffd237d as bf4831f). See run details. PostgreSQL DB size in MB: 2666 ⇒ 2662 (-0.2% change)
expand for details... |
6 tasks
5 tasks
zstadler
reviewed
Sep 16, 2020
Comment on lines
+58
to
+59
| hstore(string_agg(nullif(slice_language_tags(tags || hstore(ARRAY ['name', name]))::text, ''), | ||
| ',')) AS "tags", |
There was a problem hiding this comment.
Suggested change
| hstore(string_agg(nullif(slice_language_tags(tags || hstore(ARRAY ['name', name]))::text, ''), | |
| ',')) AS "tags", | |
| hstore(string_agg(nullif(slice_language_tags(tags)::text, ''), ',')) AS "tags", |
I can see why name_en and name_de were originally added to tags - their value was computed earlier using name, name:en and name:de:
openmaptiles/layers/transportation_name/layer.sql
Lines 27 to 28 in fb7c1ef
I fail to see the purpose of adding name to tags - name is included in the result as a separate column and it is not used by the {name_languages} expression:
|
@TomPohys are we able to proceed with breaking changes like this targeting 4.0 or do we still expect 3.x development to continue on mainline? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #769 and includes some of the same code as in #910 (rebased) by @kukulich
See #930 for all name/localization related issues.
This PR removes both
name_enandname_defields from all layers -- about 2% reduction in tile size per test below.This PR requires some changes to the styling as well:
current styles use
name_enandname_deinstead ofname:enandname:de.All other languages are already done in the new system.
TODO: decide how to handle
name_int,name:latin,name:nonlatin