Add cusine subclass for food POIs #1527
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Results evaluating commit 79d7eca (merged with base 692b0a7 as e128183). See run details. PostgreSQL DB size in MB: 4925 ⇒ 4926 (0.0% change)
expand for details... |
1ec5
reviewed
Apr 8, 2023
| - donut;coffee_shop | ||
| - ice_cream | ||
| - pizza | ||
| - pizza;italian |
There was a problem hiding this comment.
The cuisine key is currently a mismash of orthogonal ideas about food type and ethnic/national cuisine. There seems to be some interest in splitting it into two keys, but probably not enough to be relevant to OpenMapTiles yet. In the meantime, perhaps OMT could bucket the values into different feature properties. This will dramatically reduce the number of multiple-value situations, particularly in a country like Italy that’s associated with its own cuisine value.
There was a problem hiding this comment.
These particular semi-colon-separated values seem to be the direct result of iD presets for chain restaurants, and they come in high numbers, so I'm not terribly worried about treating them as a singular tag. Though I agree it would be a bit nicer in the output to bucket them.
| def_poi_mapping_cuisine: &poi_mapping_cuisine | ||
| - burger | ||
| - coffee_shop | ||
| - donut;coffee_shop |
There was a problem hiding this comment.
When there are multiple values, should the feature have multiple separate properties such as cuisine_1 and cuisine_2 (following the route_* precedent in #1152)? If not and the cuisine property ends up being set to multiple values, then
- Maybe OMT should sort the values alphabetically, because semicolon lists are supposedly unordered when it comes to
cuisine. This way the style won’t need to check for each permutation of values in a multi-value list. - Downstream, MapLibre will need to add support for splitting and joining expression operators, or better yet, an array filtering operator: Add split and join expressions maplibre/maplibre-gl-js#2064.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds select
cuisinevalues as subclass values forfast_foodandrestaurant. This allows for custom icons for common cuisine types such as "pizza", "burger", "donut", etc.