-
Notifications
You must be signed in to change notification settings - Fork 576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add parking to landuse as amenity #1438
base: master
Are you sure you want to change the base?
Conversation
Hi, do you have also some numbers, how much does it raises mbtiles on a bigger area (a state like France, or Germany)? (tests are using just some samples). Thanks |
And also (same as in #1429), please update PR by |
This is also a problem for OSM Americana, as well as any osm-carto-like style. Without an area geometry, rendering looks a little silly: |
Thanks for bringing up this topic. Yes, having parking areas is a good idea. On the other hand, there are a lot of parking places that should not be visible or have a different style (e.g. private parking). Also, underground or rooftop parking places are very common. Also showing the parking places until zoom level 14 (maybe 13) makes not much sense. If there will be more added attributes, then maybe using I think that this needs more discussion. |
In OSM Americana, we don't show parking until z17, so I'd agree that capping parking areas to z14 make sense. There are a few places you could put it.
Of all the options, I think putting it in |
I thing too, that
But it must be super careful, what parking places will be added into this layer (maybe it is not neccessary to have surface in tiles, definitely must be distinguish |
Perhaps we could start by excluding street-side parking areas, as these tend to be tiny and less interesting features to display as a polygon. I would also suggest removing parking from the |
@cbeddow wondering if you're planning to continue working on this? |
@ZeLonewolf yes I do! Sorry, I was unplugged for awhile in January and didn't have notifications on for this. |
@TomPohys when you ask for numbers: number of nodes? Square meters? Number of polygons? Data size? I can pretty quickly crunch this by querying my planet database but let me know which is best for similar proposals in the future |
Street-side parking (and the shape of those areas) has a large impact on orienteering and navigation for all classes of map user. I wouldn't exclude those as areas at higher zoom levels. It would leave awkward gaps in many places. |
@TomPohys can we run CI on this please so we can have some sense of the tile size metrics at least? |
Results evaluating commit aeb78a8 (merged with base e61442c as c95d4e6). See run details. PostgreSQL DB size in MB: 4939 ⇒ 4945 (0.1% change)
expand for details...
|
Discussion here: #1437