Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not mask SIGSEGV to hide real crash culprit/place #203

Open
wants to merge 2 commits into
base: develop/7
Choose a base branch
from

Conversation

kgardas
Copy link

@kgardas kgardas commented Jun 20, 2014

Hi, this solves issue #202

This patch fixes compilation issue on Solaris while using GNU C
for compilation. Although this is not officially supported compiler
for this OS still it is good to have it as a fall back option in case
something's going wrong and you'd like to know if this is Solaris related
issue or compiler related one.
The fix is easy, Solaris does not provide NAN nor INFINITY defines so
we're using those provided for WIN32. Please note that this is case
only when compiling with GNU C. Sun's own C compiler supports both defines
of course!
@TallTed
Copy link
Collaborator

TallTed commented Jul 28, 2021

@kgardas -- If this is still relevant, please fix the merge conflicts, so our review can go faster. If no longer relevant, please close.

@imitko @pkleef @openlink -- This PR appears to be a small change, which appears worthwhile. Please merge or address it otherwise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants