Delete palette texture before creating a new context #15787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
📦 Preview the website for this branch here: https://deploy-preview-15787--ol-site.netlify.app/. |
ahocevar
approved these changes
May 1, 2024
Co-authored-by: Andreas Hocevar <andreas.hocevar@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a WebGL layer is removed and the helper is disposed, we need to stop using any textures or other resources bound to the associated context. This change makes it so palette textures used in rendering tiles are deleted from a context before that context is disposed.
I'll admit I'm not totally happy with the regression test. Without the timeouts, removing and adding the layer does not trigger the error (in the main branch). I tried adding
map.renderSync()calls between, but couldn't get things to fail without waiting a while between the initial render and the remove/add.Fixes #15786.