Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sidecarSet initContainer support InjectPolicy #1617

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zmberg
Copy link
Member

@zmberg zmberg commented May 12, 2024

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

@kruise-bot kruise-bot requested review from FillZpp and veophi May 12, 2024 04:06
@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from zmberg by writing /assign @zmberg in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot kruise-bot added the size/L size/L: 100-499 label May 12, 2024
Copy link

codecov bot commented May 12, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 49.01%. Comparing base (0d0031a) to head (8482b05).
Report is 36 commits behind head on master.

Files Patch % Lines
...set/validating/sidecarset_create_update_handler.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1617      +/-   ##
==========================================
+ Coverage   47.91%   49.01%   +1.09%     
==========================================
  Files         162      180      +18     
  Lines       23491    18804    -4687     
==========================================
- Hits        11256     9217    -2039     
+ Misses      11014     8375    -2639     
+ Partials     1221     1212       -9     
Flag Coverage Δ
unittests 49.01% <50.00%> (+1.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zmberg zmberg force-pushed the initcontainer-injectpolicy branch 3 times, most recently from 2017277 to 89115a4 Compare May 15, 2024 11:30
@zmberg zmberg force-pushed the initcontainer-injectpolicy branch from 89115a4 to a1dbc48 Compare May 29, 2024 12:45
Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com>
@zmberg zmberg force-pushed the initcontainer-injectpolicy branch from d50d944 to 8482b05 Compare May 30, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L size/L: 100-499
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants