Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ephemeraljob validating webhook #1615

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ABNER-1
Copy link
Contributor

@ABNER-1 ABNER-1 commented May 11, 2024

Ⅰ. Describe what this PR does

fix #1614

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Invalid ejob must be rejected by webhook.
For example:
image

Ⅳ. Special notes for reviews

@kruise-bot kruise-bot requested review from FillZpp and veophi May 11, 2024 04:10
@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign veophi for approval by writing /assign @veophi in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot kruise-bot added the size/L size/L: 100-499 label May 11, 2024
Copy link

codecov bot commented May 11, 2024

Codecov Report

Attention: Patch coverage is 70.33898% with 35 lines in your changes are missing coverage. Please review.

Project coverage is 49.12%. Comparing base (0d0031a) to head (cca847d).
Report is 37 commits behind head on master.

Files Patch % Lines
pkg/webhook/ephemeraljob/validating/validation.go 74.48% 18 Missing and 7 partials ⚠️
...b/validating/ephemeraljob_create_update_handler.go 58.82% 5 Missing and 2 partials ⚠️
pkg/webhook/ephemeraljob/validating/webhooks.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1615      +/-   ##
==========================================
+ Coverage   47.91%   49.12%   +1.20%     
==========================================
  Files         162      183      +21     
  Lines       23491    18921    -4570     
==========================================
- Hits        11256     9294    -1962     
+ Misses      11014     8405    -2609     
- Partials     1221     1222       +1     
Flag Coverage Δ
unittests 49.12% <70.33%> (+1.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kruise-bot kruise-bot added size/XL size/XL: 500-999 and removed size/L size/L: 100-499 labels May 11, 2024
@kruise-bot kruise-bot added size/XXL and removed size/XL size/XL: 500-999 labels May 20, 2024
@kruise-bot kruise-bot added size/XL size/XL: 500-999 and removed size/XXL labels May 20, 2024
pkg/webhook/add_ephemeraljob.go Outdated Show resolved Hide resolved
pkg/webhook/ephemeraljob/validating/validation.go Outdated Show resolved Hide resolved
Signed-off-by: Abner-1 <Abner199709@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XL size/XL: 500-999
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request] add validating webhook for ejob
4 participants