-
Notifications
You must be signed in to change notification settings - Fork 740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Proposal] Add proposal for adding progressDeadlineSeconds in CloneSet #1520
base: master
Are you sure you want to change the base?
[Proposal] Add proposal for adding progressDeadlineSeconds in CloneSet #1520
Conversation
Signed-off-by: hantmac <hantmac@outlook.com>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1520 +/- ##
==========================================
+ Coverage 47.82% 47.97% +0.15%
==========================================
Files 161 162 +1
Lines 23395 23491 +96
==========================================
+ Hits 11188 11270 +82
- Misses 10993 11005 +12
- Partials 1214 1216 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
image: nginx:1.14.2 | ||
``` | ||
|
||
### 2. handle the logic |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cloneset support partition, so the definition of progressDeadlineSeconds may be different from deployment. If the cloneset is paused because of partition shall we still count the paused time in progress deadline ?
- One possible redefinition of progressDeadlineSeconds is the time to reach completion OR "the paused state".
- alternatively we only support progressDeadlineSeconds if partition is not set.
I think we need more feedback from the community
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we should not count the time when cloneset is paused by the partition.
Only supporting progressDeadlineSeconds
if partition is not set may be easy to implement.
More feedback is nice. Maybe we can make a vote about these two choice.
Signed-off-by: hantmac <hantmac@outlook.com>
Ⅰ. Describe what this PR does
Add proposal for support progressDeadlineSeconds in CloneSet
Ⅱ. Does this pull request fix one issue?
To fix #1468
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews