Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposal] Add proposal for adding progressDeadlineSeconds in CloneSet #1520

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

hantmac
Copy link
Member

@hantmac hantmac commented Mar 8, 2024

Ⅰ. Describe what this PR does

Add proposal for support progressDeadlineSeconds in CloneSet

Ⅱ. Does this pull request fix one issue?

To fix #1468

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

Signed-off-by: hantmac <hantmac@outlook.com>
@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign zmberg for approval by writing /assign @zmberg in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hantmac hantmac marked this pull request as draft March 8, 2024 08:10
@hantmac hantmac changed the title [Proposal] Add proposal for support progressDeadlineSeconds in CloneSet [Proposal] Add proposal for adding progressDeadlineSeconds in CloneSet Mar 8, 2024
Copy link

codecov bot commented Mar 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.97%. Comparing base (209d476) to head (b49c481).
Report is 14 commits behind head on master.

❗ Current head b49c481 differs from pull request most recent head 56517c7. Consider uploading reports for the commit 56517c7 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1520      +/-   ##
==========================================
+ Coverage   47.82%   47.97%   +0.15%     
==========================================
  Files         161      162       +1     
  Lines       23395    23491      +96     
==========================================
+ Hits        11188    11270      +82     
- Misses      10993    11005      +12     
- Partials     1214     1216       +2     
Flag Coverage Δ
unittests 47.97% <ø> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

image: nginx:1.14.2
```

### 2. handle the logic
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cloneset support partition, so the definition of progressDeadlineSeconds may be different from deployment. If the cloneset is paused because of partition shall we still count the paused time in progress deadline ?

  1. One possible redefinition of progressDeadlineSeconds is the time to reach completion OR "the paused state".
  2. alternatively we only support progressDeadlineSeconds if partition is not set.
    I think we need more feedback from the community

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we should not count the time when cloneset is paused by the partition.
Only supporting progressDeadlineSeconds if partition is not set may be easy to implement.
More feedback is nice. Maybe we can make a vote about these two choice.

Signed-off-by: hantmac <hantmac@outlook.com>
@kruise-bot kruise-bot added size/L size/L: 100-499 and removed size/M size/M: 30-99 labels Apr 2, 2024
Signed-off-by: hantmac <hantmac@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request] Support progressDeadlineSeconds in CloneSet
3 participants