Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge new branch with updated read me #1516

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

KaizenGirl1111
Copy link

@KaizenGirl1111 KaizenGirl1111 commented Feb 29, 2024

Ⅰ. Describe what this PR does

I just added a table comparing native kubernetes and kubernetes extended with OpenKruise

Ⅱ. Does this pull request fix one issue?

No, it doesn't fix any prevailing issue

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

This is a PR in special attempt to understand OpenKruise project and is maybe a very naive one :) I am all ears to reviews. I have also applied for LFX this year, if I get selected would love to learn more. I also published an interesting article explaining OpenKruise in simple words like explaining to a 5 year old - https://avniuplabdhee.hashnode.dev/openkruise-explained-like-you-are-5

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign furykerry for approval by writing /assign @furykerry in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot
Copy link

Welcome @KaizenGirl1111! It looks like this is your first PR to openkruise/kruise 🎉

@kruise-bot kruise-bot added the size/S size/S 10-29 label Feb 29, 2024
Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.19%. Comparing base (3b7c731) to head (388b0ec).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1516      +/-   ##
==========================================
- Coverage   49.21%   49.19%   -0.03%     
==========================================
  Files         157      157              
  Lines       22604    22604              
==========================================
- Hits        11125    11119       -6     
- Misses      10268    10272       +4     
- Partials     1211     1213       +2     
Flag Coverage Δ
unittests 49.19% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zmberg
Copy link
Member

zmberg commented Mar 5, 2024

@KaizenGirl1111 Good Job, and can you resolve the check fails, for example:
image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S size/S 10-29
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants