Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize func ConvertToRegistryAuths #1492

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zmberg
Copy link
Member

@zmberg zmberg commented Jan 25, 2024

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from zmberg by writing /assign @zmberg in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kruise-bot kruise-bot added the size/S size/S 10-29 label Jan 25, 2024
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.59%. Comparing base (9913b92) to head (141bb45).
Report is 11 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1492      +/-   ##
==========================================
- Coverage   48.60%   48.59%   -0.01%     
==========================================
  Files         157      157              
  Lines       22480    22480              
==========================================
- Hits        10926    10924       -2     
- Misses      10352    10353       +1     
- Partials     1202     1203       +1     
Flag Coverage Δ
unittests 48.59% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: liheng.zms <liheng.zms@alibaba-inc.com>
@kruise-bot kruise-bot added size/M size/M: 30-99 and removed size/S size/S 10-29 labels Jan 26, 2024
@kruise-bot
Copy link

@zmberg: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants