Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add preNormal hook for Advanced StatefulSet #1277

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

veophi
Copy link
Member

@veophi veophi commented May 8, 2023

Ⅰ. Describe what this PR does

fixes #1213

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

Signed-off-by: mingzhou.swx <mingzhou.swx@alibaba-inc.com>
@kruise-bot kruise-bot requested review from Fei-Guo and zmberg May 8, 2023 07:26
@kruise-bot kruise-bot added the size/S size/S 10-29 label May 8, 2023
@zmberg
Copy link
Member

zmberg commented May 9, 2023

/lgtm

@kruise-bot
Copy link

@veophi: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

stale bot commented Nov 7, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Nov 7, 2023
@stale stale bot closed this Nov 14, 2023
@zmberg zmberg reopened this Mar 7, 2024
@stale stale bot removed the wontfix This will not be worked on label Mar 7, 2024
@kruise-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from veophi by writing /assign @veophi in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zmberg
Copy link
Member

zmberg commented Mar 7, 2024

/hold

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request] Add lifecycle preNormal for Advanced StatefulSet
3 participants