add ephemeraljob validating webhook #1615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ABNER-1
force-pushed
the
add-ephemeraljob-webhook
branch
from
9a68014
to
06ed285
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1615 +/- ##
==========================================
+ Coverage 47.91% 49.16% +1.24%
==========================================
Files 162 183 +21
Lines 23491 18921 -4570
==========================================
- Hits 11256 9302 -1954
+ Misses 11014 8398 -2616
Partials 1221 1221
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
furykerry
reviewed
May 11, 2024
pkg/webhook/ephemeraljob/validating/ephemeraljob_create_update_handler.go
Outdated
Show resolved
Hide resolved
ABNER-1
force-pushed
the
add-ephemeraljob-webhook
branch
from
06ed285
to
3037dd3
Compare
ABNER-1
force-pushed
the
add-ephemeraljob-webhook
branch
from
3037dd3
to
e0a56bf
Compare
ABNER-1
force-pushed
the
add-ephemeraljob-webhook
branch
from
e0a56bf
to
7838bde
Compare
furykerry
reviewed
May 20, 2024
ABNER-1
force-pushed
the
add-ephemeraljob-webhook
branch
from
7838bde
to
fc48f67
Compare
ABNER-1
force-pushed
the
add-ephemeraljob-webhook
branch
from
fc48f67
to
c77a185
Compare
zmberg
reviewed
May 31, 2024
ABNER-1
force-pushed
the
add-ephemeraljob-webhook
branch
2 times, most recently
from
3d67224
to
cca847d
Compare
Signed-off-by: Abner-1 <Abner199709@gmail.com>
ABNER-1
force-pushed
the
add-ephemeraljob-webhook
branch
from
cca847d
to
7b495c6
Compare
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: furykerry The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR does
fix #1614
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Invalid ejob must be rejected by webhook.
For example:
Ⅳ. Special notes for reviews