Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature request] Support progressDeadlineSeconds in CloneSet #1468

Open
ronaknnathani opened this issue Dec 12, 2023 · 3 comments · May be fixed by #1520
Open

[feature request] Support progressDeadlineSeconds in CloneSet #1468

ronaknnathani opened this issue Dec 12, 2023 · 3 comments · May be fixed by #1520
Assignees
@hantmac
Labels
help wanted Extra attention is needed kind/feature-request kind/good-first-issue Good for newcomers

Comments

@ronaknnathani
Copy link

ronaknnathani commented Dec 12, 2023 •
edited

What would you like to be added:
Add support for progressDeadlineSeconds in CloneSet. .spec.progressDeadlineSeconds is an optional field in Deployment that specifies the number of seconds one wants to wait for their Deployment to progress before the system reports back that the Deployment has failed progressing - surfaced as a condition with type: Progressing, status: "False" and reason: ProgressDeadlineExceeded in the status of the resource.

Reference: https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#progress-deadline-seconds

Why is this needed:
In the case of CloneSets, if the rollout is stuck for any reason - image pull errors, insufficient permissions, insufficient capacity, unhealthy app, etc. - currently there is no way to identify that the rollout is stuck by looking at the CloneSet status. With a feature like progressDeadlineSeconds, one can specify a time and if the rollout hasn't made any progress for that period, the CloneSet status can be updated to reflect that. The CloneSet controller would still continue to reconcile the requests, however, this status allows continuous delivery pipelines and any other controllers that build on top of CloneSet to know that the rollout failed.
@furykerry furykerry added help wanted Extra attention is needed kind/good-first-issue Good for newcomers labels Dec 13, 2023
@ronaknnathani
Copy link
Author

@furykerry do we need a proposal for this or do you think we can send a PR for review?

@furykerry
Copy link
Member

yes, plz draft a proposal for this feature in https://github.com/openkruise/kruise/blob/master/docs/proposals

@hantmac hantmac linked a pull request Mar 8, 2024 that will close this issue
Draft
@hantmac hantmac assigned hantmac and unassigned FillZpp Mar 8, 2024
@furykerry
Copy link
Member

@ronaknnathani we're drafting a proposal for this feature, however the definition of progressDeadlineSeconds can be different from Deployment because cloneset support partition. Can you give us some feedback about the potential use case of progressDeadlineSeconds when partition is set ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hantmac hantmac

Labels
help wanted Extra attention is needed kind/feature-request kind/good-first-issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Proposal] Add proposal for adding progressDeadlineSeconds in CloneSet hantmac/kruise
4 participants
@furykerry @ronaknnathani @FillZpp @hantmac