Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(applyLayoutTransform): fix calculate matrix not include scrollLef… #1447

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(applyLayoutTransform): fix calculate matrix not include scrollLef… #1447

wants to merge 3 commits into from

Conversation

pba-cra
Copy link

@pba-cra pba-cra commented Jul 19, 2022

fix error which calculate child to parent position not include scrollLeft and scrollTop

answershuto
answershuto reviewed Jul 19, 2022
View reviewed changes
Copy link
Member

@answershuto answershuto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

用例补充一下吧

@pba-cra
Copy link
Author

pba-cra commented Jul 19, 2022

用例补充一下吧

我现在本地跑 test 好多报错啊 你们不报吗

@answershuto
Copy link
Member

本地是有可能会报错的，你用 github 的 ci 跑吧，本地测试可以把某个要验证的 it 改成 fit。

@andycall
Copy link
Member

这个情况还需要补充一个测试用例

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andycall andycall Awaiting requested review from andycall

@answershuto answershuto Awaiting requested review from answershuto

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pba-cra @answershuto @andycall