Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jlinkOptions configuration #109

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

abhinayagarwal
Copy link
Collaborator

Fix #104

Copy link
Contributor

@betanzos betanzos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test method JavaFXRunMojoTestCase#testSplitComplexArgumentString() should be removed as the same test was created in JavaFXBaseMojoTest class.

src/test/java/org/openjfx/JavaFXBaseMojoTest.java Outdated Show resolved Hide resolved
@HGuillemet
Copy link

PR tested and working, but see related issue in this comment:
when we want to add all module path to the image and to the module graph, we need <option>--add-modules ALL-MODULE-PATH</option> for the run target and <option>--add-module ALL-SYSTEM-PATH</option> for the jlink target (launcher option). Unless I missed something, It's not possible currently to configure two different values for <option>.
What about a runOption and launcherOption instead of (or in addition to) option ?

@abhinayagarwal
Copy link
Collaborator Author

In this case, runOption and launcherOption seems like the only way out.

Having said that, option is provided by default to all configuration and cannot be removed. Will this create confusion to future users of the plugin (as its usage will be deprecated but the parameter will still be present) ?

@HGuillemet
Copy link

You can keep option without deprecating it, as a way to specify common options to both goals. And add runOption and launcherOption just for specific ones.

@HGuillemet
Copy link

Could we move on about this issue ? Would you be interested in a PR adding runOption and launcherOption ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configuration to provide jlink options
3 participants