Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP2Loader with proxy enabled #1412

Closed
wants to merge 2 commits into from
Closed

HTTP2Loader with proxy enabled #1412

wants to merge 2 commits into from

Conversation

pisek
Copy link

@pisek pisek commented Mar 20, 2024

There is a lack of proxy setting in http2 connection done in HTTP2Loader (which further does not allow proxy to be used in WebView)


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Error

 ⚠️ OCA signatory status must be verified

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1412/head:pull/1412
$ git checkout pull/1412

Update a local copy of the PR:
$ git checkout pull/1412
$ git pull https://git.openjdk.org/jfx.git pull/1412/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1412

View PR using the GUI difftool:
$ git pr show -t 1412

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1412.diff

There is a lack of proxy setting in http2 connection done in HTTP2Loader
@bridgekeeper bridgekeeper bot added the oca Needs verification of OCA signatory status label Mar 20, 2024
@bridgekeeper
Copy link

bridgekeeper bot commented Mar 20, 2024

Hi @pisek, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user pisek" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@openjdk
Copy link

openjdk bot commented Mar 20, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@kevinrushforth
Copy link
Member

@pisek As with your previously submitted PR #1318 this PR is not ready to be reviewed.

Please read the CONTRIBUTING guidelines -- specifically the "Before submitting a pull request" section -- for a list of steps that will be needed before we will even look at this PR.

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 18, 2024

@pisek This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented May 17, 2024

@pisek This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

@bridgekeeper bridgekeeper bot closed this May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
oca Needs verification of OCA signatory status
2 participants