-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8315559: Delay TempSymbol cleanup to avoid symbol table churn #2424
8315559: Delay TempSymbol cleanup to avoid symbol table churn #2424
Conversation
👋 Welcome back ogillespie! A progress list of the required criteria for merging this PR into |
@olivergillespie This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee, @shipilev) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
|
/approval request Fixes non-trivial performance regression in class-loading (dacapo pmd). Not clean due to file movement but simple to merge. Confirmed that the performance regression is present before the change and fixed after, using the original benchmark. Medium risk as it affects Symbol creation, but has been working in tip and 21 for a few months with no associated issues. |
@olivergillespie |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me.
I'll approve this for the October update. |
Cool, thanks! |
@olivergillespie This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
(keepalive) |
/integrate |
@olivergillespie |
/sponsor |
@shipilev @olivergillespie Pushed as commit 1b807f9. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Hi all,
This pull request contains a backport of commit d23f4f12 from the openjdk/jdk repository.
The commit being backported was authored by Oli Gillespie on 4 Dec 2023 and was reviewed by Coleen Phillimore, Kim Barrett and Aleksey Shipilev.
Thanks!
The backport is not clean.
symbolHandle
does not exist in 17, so I put the same functionality insymbolTable
whereTempNewSymbol
resides for 17. The functionality itself is essentially identical, with the other change being thatmaybe_decrement_refcount
helper also does not exist, so I just added a null check.test/hotspot/gtest/classfile/test_placeholders.cpp
does not exist, so it didn't need to be fixed.test_symbolTable.cpp
failed as expected before fixing, and applied cleanly.Testing on the original benchmark confirms this fixes the performance regression:
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2424/head:pull/2424
$ git checkout pull/2424
Update a local copy of the PR:
$ git checkout pull/2424
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2424/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2424
View PR using the GUI difftool:
$ git pr show -t 2424
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2424.diff
Webrev
Link to Webrev Comment