8330066: HeapDumpPath and HeapDumpGzipLevel VM options do not mention HeapDumpBeforeFullGC and HeapDumpAfterFullGC

[alexmenkov]

The fix updates descriptions of HeapDumpPath/HeapDumpGzipLevel and HeapDumpBeforeFullGC/HeapDumpAfterFullGC/HeapDumpOnOutOfMemoryError VM options

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8330066: HeapDumpPath and HeapDumpGzipLevel VM options do not mention HeapDumpBeforeFullGC and HeapDumpAfterFullGC (Bug - P4)

Reviewers

• Chris Plummer (@plummercj - Reviewer)
• David Holmes (@dholmes-ora - Reviewer)
• Yi Yang (@y1yang0 - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19224/head:pull/19224
$ git checkout pull/19224

Update a local copy of the PR:
$ git checkout pull/19224
$ git pull https://git.openjdk.org/jdk.git pull/19224/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19224

View PR using the GUI difftool:
$ git pr show -t 19224

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19224.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back amenkov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@alexmenkov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8330066: HeapDumpPath and HeapDumpGzipLevel VM options do not mention HeapDumpBeforeFullGC and HeapDumpAfterFullGC

Reviewed-by: cjplummer, dholmes, yyang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 18 new commits pushed to the master branch:

• ea5eb74: 8326404: Assertion error when trying to compile switch with fallthrough with pattern
• beea530: 8331907: BigInteger and BigDecimal should use optimized division
• 440782e: 8331466: Problemlist serviceability/dcmd/gc/RunFinalizationTest.java on generic-all
• 5ded8da: 8332085: Remove 10 year old transition check in GenerateCurrencyData tool
• 7c2c24f: 8261433: Better pkcs11 performance for libpkcs11:C_EncryptInit/libpkcs11:C_DecryptInit
• ff4bf1c: 8332102: Add @since to package-info of jdk.security.jarsigner
• abf54bb: 8332100: Add missing @since to KeyValue::EC_TYPE in java.xml.crypto
• 1484153: 8332080: Update troff man page for javadoc
• 391bbbc: 8330584: IGV: XML does not save all node properties
• adaa509: 8327499: MethodHandleStatics.traceLambdaForm includes methods that cannot be generated
• ... and 8 more: https://git.openjdk.org/jdk/compare/5e8e8ef6565e82a23626fe16893f93870dae1012...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@alexmenkov The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (7da2dbde)
• 00: Full (b3ed45e3)

[y1yang0]

Bad format, otherwise looks good.

[plummercj]

/label serviceability

[openjdk]

@plummercj
The serviceability label was successfully added.

[dholmes-ora]

Updates look good.

FWIW the Java command reference doesn't mention the before/after full GC flags either.

[alexmenkov]

/integrate

[openjdk]

Going to push as commit 43b109b.
Since your change was applied there have been 43 commits pushed to the master branch:

• 7cff04f: 8330276: Console methods with explicit Locale
• 8a4315f: 8331987: Enhance stacktrace clarity for CompletableFuture CancellationException
• 491b3b4: 8332256: Shenandoah: Do not visit heap threads during shutdown
• 9c02c8d: 8332255: Shenandoah: Remove duplicate definition of init mark closure
• 42ccb74: 8331940: ClassFile API ArrayIndexOutOfBoundsException with certain class files
• 61aff6d: 8332112: Update nsk.share.Log to don't print summary during VM shutdown hook
• 30bb066: 8332003: Clarify javadoc for MemoryLayout::offsetHandle
• c4867c6: 8329273: C2 SuperWord: Some basic MemorySegment IR tests
• 8032d64: 8332245: C2: missing record_for_ign() call in GraphKit::must_be_not_null()
• fa043ae: 8294880: Review running time of jdk/internal/shellsupport/doc/JavadocHelperTest.java
• ... and 33 more: https://git.openjdk.org/jdk/compare/5e8e8ef6565e82a23626fe16893f93870dae1012...master

Your commit was automatically rebased without conflicts.

[openjdk]

@alexmenkov Pushed as commit 43b109b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.