-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8331432: Clean up comments in GenArguments::initialize_size_info() #19223
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back xiaotaonan! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
@xiaotaonan The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
The issue states there are two places which need to be revised. So the warning message is good to be adjusted in this PR. |
@@ -301,8 +301,6 @@ void GenArguments::initialize_size_info() { | |||
// generation to fit as well. | |||
// If the user has explicitly set an OldSize that is inconsistent | |||
// with other command line flags, issue a warning. | |||
// The generation minimums and the overall heap minimum should | |||
// be within one generation alignment. | |||
if (initial_old_size > MaxOldSize) { | |||
log_warning(gc, ergo)("Inconsistency between maximum heap size and maximum " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JDK-8331432 also mentions this warning message as needing cleanup.
It should be similar to the one below about initial vs min old size, rather than incorrectly mentioning
max heap size and printing MaxHeapSize.
Except it would be useful if both includes both the initial and bound values.
Also, prefer "%zu" rather than SIZE_FORMAT when updating the messages.
Clean up comments in GenArguments::initialize_size_info()
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19223/head:pull/19223
$ git checkout pull/19223
Update a local copy of the PR:
$ git checkout pull/19223
$ git pull https://git.openjdk.org/jdk.git pull/19223/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 19223
View PR using the GUI difftool:
$ git pr show -t 19223
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19223.diff
Webrev
Link to Webrev Comment