Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8331432: Clean up comments in GenArguments::initialize_size_info() #19223

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

xiaotaonan
Copy link

@xiaotaonan xiaotaonan commented May 14, 2024

Clean up comments in GenArguments::initialize_size_info()


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8331432: Clean up comments in GenArguments::initialize_size_info() (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19223/head:pull/19223
$ git checkout pull/19223

Update a local copy of the PR:
$ git checkout pull/19223
$ git pull https://git.openjdk.org/jdk.git pull/19223/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19223

View PR using the GUI difftool:
$ git pr show -t 19223

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19223.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 14, 2024

👋 Welcome back xiaotaonan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 14, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the rfr Pull request is ready for review label May 14, 2024
@openjdk
Copy link

openjdk bot commented May 14, 2024

@xiaotaonan The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label May 14, 2024
@mlbridge
Copy link

mlbridge bot commented May 14, 2024

Webrevs

@xiaotaonan
Copy link
Author

@lgxbslgx

@lgxbslgx
Copy link
Member

The issue states there are two places which need to be revised. So the warning message is good to be adjusted in this PR.

@@ -301,8 +301,6 @@ void GenArguments::initialize_size_info() {
// generation to fit as well.
// If the user has explicitly set an OldSize that is inconsistent
// with other command line flags, issue a warning.
// The generation minimums and the overall heap minimum should
// be within one generation alignment.
if (initial_old_size > MaxOldSize) {
log_warning(gc, ergo)("Inconsistency between maximum heap size and maximum "

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JDK-8331432 also mentions this warning message as needing cleanup.
It should be similar to the one below about initial vs min old size, rather than incorrectly mentioning
max heap size and printing MaxHeapSize.
Except it would be useful if both includes both the initial and bound values.
Also, prefer "%zu" rather than SIZE_FORMAT when updating the messages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org rfr Pull request is ready for review
3 participants