Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8322008: Exclude some CDS tests from running with -Xshare:off #19221

Closed

Conversation

calvinccheung
Copy link
Member

@calvinccheung calvinccheung commented May 13, 2024

Some CDS tests throws a SkippedException when -Xshare:off is specified.
This change adds a hotspot_runtime_non_cds_mode test group for excluding those tests.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8322008: Exclude some CDS tests from running with -Xshare:off (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19221/head:pull/19221
$ git checkout pull/19221

Update a local copy of the PR:
$ git checkout pull/19221
$ git pull https://git.openjdk.org/jdk.git pull/19221/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19221

View PR using the GUI difftool:
$ git pr show -t 19221

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19221.diff

Webrev

Link to Webrev Comment

@calvinccheung
Copy link
Member Author

/label add hotspot-runtime

@bridgekeeper
Copy link

bridgekeeper bot commented May 13, 2024

👋 Welcome back ccheung! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@calvinccheung
Copy link
Member Author

/label add hotspot-test

@openjdk
Copy link

openjdk bot commented May 13, 2024

@calvinccheung This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8322008: Exclude some CDS tests from running with -Xshare:off

Reviewed-by: lmesnik, iklam

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 44 new commits pushed to the master branch:

  • e91492a: 8313674: (fc) java/nio/channels/FileChannel/BlockDeviceSize.java should test for more block devices
  • 95a6013: 8332042: Move MEMFLAGS to its own include file
  • 5a4415a: 8331858: [nmt] VM.native_memory statistics should work in summary mode
  • 4ba7447: 8326957: Implement JEP 474: ZGC: Generational Mode by Default
  • 7ce4a13: 8332130: RISC-V: remove wrong instructions of Vector Crypto Extension
  • ea5eb74: 8326404: Assertion error when trying to compile switch with fallthrough with pattern
  • beea530: 8331907: BigInteger and BigDecimal should use optimized division
  • 440782e: 8331466: Problemlist serviceability/dcmd/gc/RunFinalizationTest.java on generic-all
  • 5ded8da: 8332085: Remove 10 year old transition check in GenerateCurrencyData tool
  • 7c2c24f: 8261433: Better pkcs11 performance for libpkcs11:C_EncryptInit/libpkcs11:C_DecryptInit
  • ... and 34 more: https://git.openjdk.org/jdk/compare/a643d6c7ac8a7bc0d3a288c1ef3f07876cf70590...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label May 13, 2024
@openjdk
Copy link

openjdk bot commented May 13, 2024

@calvinccheung
The hotspot-runtime label was successfully added.

@openjdk
Copy link

openjdk bot commented May 13, 2024

@calvinccheung
The label hotspot-test is not a valid label.
These labels are valid:

  • graal
  • serviceability
  • hotspot
  • hotspot-compiler
  • ide-support
  • kulla
  • i18n
  • shenandoah
  • jdk
  • javadoc
  • security
  • hotspot-runtime
  • jmx
  • build
  • nio
  • client
  • core-libs
  • compiler
  • net
  • hotspot-gc
  • hotspot-jfr

@calvinccheung calvinccheung marked this pull request as ready for review May 13, 2024 18:34
@openjdk openjdk bot added the rfr Pull request is ready for review label May 13, 2024
@mlbridge
Copy link

mlbridge bot commented May 13, 2024

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 13, 2024
Copy link
Member

@iklam iklam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@calvinccheung
Copy link
Member Author

Thanks @lmesnik, @iklam for the review.

/integrate

@openjdk
Copy link

openjdk bot commented May 14, 2024

Going to push as commit 4d32c60.
Since your change was applied there have been 44 commits pushed to the master branch:

  • e91492a: 8313674: (fc) java/nio/channels/FileChannel/BlockDeviceSize.java should test for more block devices
  • 95a6013: 8332042: Move MEMFLAGS to its own include file
  • 5a4415a: 8331858: [nmt] VM.native_memory statistics should work in summary mode
  • 4ba7447: 8326957: Implement JEP 474: ZGC: Generational Mode by Default
  • 7ce4a13: 8332130: RISC-V: remove wrong instructions of Vector Crypto Extension
  • ea5eb74: 8326404: Assertion error when trying to compile switch with fallthrough with pattern
  • beea530: 8331907: BigInteger and BigDecimal should use optimized division
  • 440782e: 8331466: Problemlist serviceability/dcmd/gc/RunFinalizationTest.java on generic-all
  • 5ded8da: 8332085: Remove 10 year old transition check in GenerateCurrencyData tool
  • 7c2c24f: 8261433: Better pkcs11 performance for libpkcs11:C_EncryptInit/libpkcs11:C_DecryptInit
  • ... and 34 more: https://git.openjdk.org/jdk/compare/a643d6c7ac8a7bc0d3a288c1ef3f07876cf70590...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 14, 2024
@openjdk openjdk bot closed this May 14, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 14, 2024
@openjdk
Copy link

openjdk bot commented May 14, 2024

@calvinccheung Pushed as commit 4d32c60.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@calvinccheung calvinccheung deleted the 8322008-Xshareoff branch May 14, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
3 participants