-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8322008: Exclude some CDS tests from running with -Xshare:off #19221
Conversation
/label add hotspot-runtime |
👋 Welcome back ccheung! A progress list of the required criteria for merging this PR into |
/label add hotspot-test |
@calvinccheung This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 44 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
@calvinccheung |
@calvinccheung
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Going to push as commit 4d32c60.
Your commit was automatically rebased without conflicts. |
@calvinccheung Pushed as commit 4d32c60. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Some CDS tests throws a
SkippedException
when-Xshare:off
is specified.This change adds a
hotspot_runtime_non_cds_mode
test group for excluding those tests.Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19221/head:pull/19221
$ git checkout pull/19221
Update a local copy of the PR:
$ git checkout pull/19221
$ git pull https://git.openjdk.org/jdk.git pull/19221/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 19221
View PR using the GUI difftool:
$ git pr show -t 19221
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19221.diff
Webrev
Link to Webrev Comment