8331934: [s390x] Add support for primitive array C1 clone intrinsic #19220
Conversation
* Clone calls that involve Phi nodes are not supported. * Add unimplemented stubs for other platforms.
* Copy state including locals for clone so that reexecution works as expected.
* Added a jtreg test to verify the null check works. Without the fix this test fails with a SEGV crash.
This reverts commit fe5d916.
* Combine array length, new type array and arraycopy for clone in c1 graph. * Add OmitCheckFlags to skip arraycopy checks. * Instantiate ArrayCopyStub only if necessary. * Avoid zeroing newly created arrays for clone. * Add array null after c1 clone compilation test. * Pass force reexecute to intrinsic via value stack. This is needed to be able to deoptimize correctly this intrinsic. * When new type array or array copy are used for the clone intrinsic, their state needs to be based on the state before for deoptimization to work as expected.
Co-authored-by: Boris <42576543+bulasevich@users.noreply.github.com>
* Added byte[] and long[] tests. * Verified that the cloned array has the same contents. * Increase number of iterations reach tier 3 threshold.
Co-authored-by: Dean Long <17332032+dean-long@users.noreply.github.com>
|
👋 Welcome back amitkumar! A progress list of the required criteria for merging this PR into |
|
@offamitkumar This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 67 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
openjdk
bot
changed the title
|
@offamitkumar The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
|
@RealLucy @TheRealMDoerr Would you please review this one. :-) Testing seems clear on s390x. I have posted Benchmark result as well. Please let me know if any further testing is required. |
|
The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork: git checkout c1_clone_intr
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push |
|
@offamitkumar this pull request can not be integrated into git checkout c1_clone_intr
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push |
openjdk
bot
added
the
merge-conflict
openjdk
bot
removed
the
merge-conflict
|
Result from the LPAR: |
pinging you again, if you got bandwidth then please review it. |
|
@galderz if possible can you review this ? Maybe this could ease you a bit while review: Testing for |
|
@offamitkumar I'm no s390 expert, so I can only do a light review on the code. The changes look good to me and the benchmark results show improvements. One thing I would suggest is maybe expanding the testing a bit, e.g. hotspot_compiler, hotspot_gc, hotspot_serviceability, hotspot_runtime, and tier1-3 see #17667 (comment) for further details. |
|
Ran this command: |
|
Thanks Martin & Sid for approval ;-) /integrate |
|
Going to push as commit ae9ad86.
Your commit was automatically rebased without conflicts. |
openjdk
bot
removed
ready
|
@offamitkumar Pushed as commit ae9ad86. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Adds JDK-8302850 Port for s390x.
Testing:
BenchMarking:
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19220/head:pull/19220$ git checkout pull/19220Update a local copy of the PR:
$ git checkout pull/19220$ git pull https://git.openjdk.org/jdk.git pull/19220/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 19220View PR using the GUI difftool:
$ git pr show -t 19220Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19220.diff
Webrev
Link to Webrev Comment